Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 2399533002: Pull in vr_shell code for webvr (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/chrome_jni_registrar.cc
diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc
index b702d527a1ebe1683d574e8f20fc1ebfa96a6ef7..944eedf91911daae0803c4e9310bc31daabe30f5 100644
--- a/chrome/browser/android/chrome_jni_registrar.cc
+++ b/chrome/browser/android/chrome_jni_registrar.cc
@@ -175,7 +175,7 @@
#include "printing/printing_context_android.h"
#endif
-#if defined(ENABLE_VR_SHELL)
+#if defined(ENABLE_VR_SHELL) || defined(ENABLE_WEBVR)
#include "chrome/browser/android/vr_shell/vr_shell.h"
agrieve 2016/10/07 17:36:43 can these be vr_common/vr_common.h?
bshe 2016/10/07 20:36:22 I think it probably makes sense to keep vr_shell A
#include "chrome/browser/android/vr_shell/vr_shell_delegate.h"
#endif
@@ -377,7 +377,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {
{"UsbChooserDialogAndroid", UsbChooserDialogAndroid::Register},
{"Variations", variations::android::RegisterVariations},
{"VariationsSession", chrome::android::RegisterVariationsSession},
-#if defined(ENABLE_VR_SHELL)
+#if defined(ENABLE_VR_SHELL) || defined(ENABLE_WEBVR)
{"VrShell", vr_shell::RegisterVrShell},
{"VrShellDelegate", vr_shell::RegisterVrShellDelegate},
#endif

Powered by Google App Engine
This is Rietveld 408576698