Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/BUILD.gn

Issue 2399533002: Pull in vr_shell code for webvr (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | chrome/browser/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index fcf028fed554a6b822c8731be66abbda756b175c..2212ca8674ded78f054e8bf90755e2470034318e 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -246,9 +246,7 @@ android_library("chrome_java") {
]
}
- # VrActivity currently depends on ChromeTabbedActivity which is part of
- # android_java_ui.
- if (enable_vr_shell && android_java_ui) {
+ if ((enable_vr_shell || enable_webvr) && android_java_ui) {
agrieve 2016/10/05 19:04:58 nit: remove android_java_ui (here and in the other
bshe 2016/10/05 19:53:06 Done.
java_files += chrome_vr_java_sources
deps += [
"//third_party/gvr-android-sdk:gvr_base_java",
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | chrome/browser/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698