Issue 23995020: switch to a new canvas every once in a while in picture_record_unique

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23995020: switch to a new canvas every once in a while in picture_record_unique (Closed)

Created:
7 years, 3 months ago by mtklein

Modified:
7 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

switch to a new canvas every once in a while in picture_record_unique BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11321

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	bench/PictureRecordBench.cpp	View		3 chunks	+13 lines, -7 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

https://codereview.chromium.org/23995020/diff/1/bench/PictureRecordBench.cpp File bench/PictureRecordBench.cpp (right): https://codereview.chromium.org/23995020/diff/1/bench/PictureRecordBench.cpp#newcode33 bench/PictureRecordBench.cpp:33: virtual void onDraw(SkCanvas*) { Don't think we need most ...

7 years, 3 months ago (2013-09-17 16:19:33 UTC) #2

mtklein

7 years, 3 months ago (2013-09-17 16:55:10 UTC) #3

mtklein

7 years, 3 months ago (2013-09-17 17:14:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r11321 (presubmit successful).

Expand Messages | Collapse Messages