Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23995018: Fix lifetime handling of SVGPropertyTearOffs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix ownership Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index e1973715d34cacf44cc6ff67d877bb026f173504..4414e8bc935668e0148742a0b5b60c68c17600b8 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -1583,10 +1583,9 @@ END
my $selfIsTearOffType = IsSVGTypeNeedingTearOff($interfaceName);
if ($selfIsTearOffType) {
- AddToImplIncludes("core/svg/properties/SVGStaticPropertyWithParentTearOff.h");
- $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyWithParentTearOff<$implClassName, /;
-
- $wrappedValue = "WTF::getPtr(${tearOffType}::create(wrapper, $expression, $updateMethod))";
+ AddToImplIncludes("core/svg/properties/SVGMatrixTearOff.h");
+ # FIXME: Don't create a new one everytime we access the matrix property. This means, e.g, === won't work.
+ $wrappedValue = "WTF::getPtr(SVGMatrixTearOff::create(wrapper, $expression))";
} else {
AddToImplIncludes("core/svg/properties/SVGStaticPropertyTearOff.h");
$tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$implClassName, /;
« no previous file with comments | « LayoutTests/svg/transforms/svg-matrix-tearoff-crash-expected.txt ('k') | Source/core/svg/properties/SVGMatrixTearOff.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698