Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index 87ff11ed59ee850994a47c63880b6cbbf4c98cb3..acc142bf961cf53bc93bc6af0fce71e08f48a2fb 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -98,13 +98,6 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,
DontMarkAsReferenced,
};
- // Exposed for testing.
- static Resource* create(
- const ResourceRequest& request,
- Type type,
- const ResourceLoaderOptions& options = ResourceLoaderOptions()) {
- return new Resource(request, type, options);
- }
virtual ~Resource();
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698