third_party/WebKit/Source/core/fetch/Resource.h - Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index b6733bbb5e5a4f4519c6f4cff58ce1b89447579b..4000c24a4cc9a54d0346a74ae08d3aa6249aeb54 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -98,13 +98,6 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,

DontMarkAsReferenced,

};

- // Exposed for testing.

- static Resource* create(

- const ResourceRequest& request,

- Type type,

- const ResourceLoaderOptions& options = ResourceLoaderOptions()) {

- return new Resource(request, type, options);

- }

virtual ~Resource();

DECLARE_VIRTUAL_TRACE();