Create multiple compilation jobs for ignition if compiling multiple literals

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include <memory>
+#include <vector>
 
 #include "src/allocation.h"
 #include "src/bailout-reason.h"
 #include "src/contexts.h"
 #include "src/isolate.h"
 #include "src/zone/zone.h"
 
 namespace v8 {
 namespace internal {
 
 // Forward declarations.
 class CompilationInfo;
 class CompilationJob;
 class JavaScriptFrame;
 class ParseInfo;
 class ScriptData;
 
+// Used by indicate whether Compiler::GetSharedFunctionInfo should trigger a
+// compilation.
+enum class ShouldCompile { kIfNecessary, kNever };
+
 // The V8 compiler API.
 //
 // This is the central hub for dispatching to the various compilers within V8.
 // Logic for which compiler to choose and how to wire compilation results into
 // the object heap should be kept inside this class.
 //
 // General strategy: Scripts are translated into anonymous functions w/o
 // parameters which then can be executed. If the source code contains other
 // functions, they might be compiled and allocated as part of the compilation
 // of the source code or deferred for lazy compilation at a later point.
 class Compiler : public AllStatic {
  public:
   enum ClearExceptionFlag { KEEP_EXCEPTION, CLEAR_EXCEPTION };
   enum ConcurrencyMode { NOT_CONCURRENT, CONCURRENT };
   enum CompilationTier { INTERPRETED, BASELINE, OPTIMIZED };
 
   // ===========================================================================
   // The following family of methods ensures a given function is compiled. The
   // general contract is that failures will be reported by returning {false},
   // whereas successful compilation ensures the {is_compiled} predicate on the
   // given function holds (except for live-edit, which compiles the world).
 
   static bool Compile(Handle<JSFunction> function, ClearExceptionFlag flag);
   static bool CompileBaseline(Handle<JSFunction> function);
   static bool CompileOptimized(Handle<JSFunction> function, ConcurrencyMode);
   static bool CompileDebugCode(Handle<JSFunction> function);
   static bool CompileDebugCode(Handle<SharedFunctionInfo> shared);
   static MaybeHandle<JSArray> CompileForLiveEdit(Handle<Script> script);
 
-  // Prepare a compilation job for unoptimized code. Requires ParseAndAnalyse.
-  static CompilationJob* PrepareUnoptimizedCompilationJob(
-      CompilationInfo* info);
+  // Prepare a series of compilation jobs for unoptimized code. Requires
+  // ParseAndAnalyse.
+  static std::vector<std::unique_ptr<CompilationJob>>
+  PrepareUnoptimizedCompilationJobs(CompilationInfo* info);
 
   // Generate and install code from previously queued compilation job.
   static bool FinalizeCompilationJob(CompilationJob* job);
 
   // Give the compiler a chance to perform low-latency initialization tasks of
   // the given {function} on its instantiation. Note that only the runtime will
   // offer this chance, optimized closure instantiation will not call this.
   static void PostInstantiation(Handle<JSFunction> function, PretenureFlag);
 
   // Parser::Parse, then Compiler::Analyze.
@@ skipping 39 matching lines @@
       Handle<Object> source_map_url, Handle<Context> context,
       v8::Extension* extension, ScriptData** cached_data,
       ScriptCompiler::CompileOptions compile_options,
       NativesFlag is_natives_code, bool is_module);
 
   // Create a shared function info object for a Script that has already been
   // parsed while the script was being loaded from a streamed source.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForStreamedScript(
       Handle<Script> script, ParseInfo* info, int source_length);
 
-  // Create a shared function info object (the code may be lazily compiled).
+  // Create a shared function info object (the code may be lazily compiled if
+  // |should_compile| is kIfNecessary).
   static Handle<SharedFunctionInfo> GetSharedFunctionInfo(
-      FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer);
+      FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer,
+      ShouldCompile should_compile = ShouldCompile::kIfNecessary);
 
   // Create a shared function info object for a native function literal.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForNative(
       v8::Extension* extension, Handle<String> name);
 
   // ===========================================================================
   // The following family of methods provides support for OSR. Code generated
   // for entry via OSR might not be suitable for normal entry, hence will be
   // returned directly to the caller.
   //
@@ skipping 22 matching lines @@
   enum class State {
     kReadyToPrepare,
     kReadyToExecute,
     kReadyToFinalize,
     kSucceeded,
     kFailed,
   };
 
   CompilationJob(Isolate* isolate, CompilationInfo* info,
                  const char* compiler_name,
-                 State initial_state = State::kReadyToPrepare)
-      : info_(info),
-        compiler_name_(compiler_name),
-        state_(initial_state),
-        stack_limit_(isolate->stack_guard()->real_climit()) {}
-  virtual ~CompilationJob() {}
+                 State initial_state = State::kReadyToPrepare);
+  virtual ~CompilationJob();
 
   // Prepare the compile job. Must be called on the main thread.
   MUST_USE_RESULT Status PrepareJob();
 
   // Executes the compile job. Can be called on a background thread if
   // can_execute_on_background_thread() returns true.
   MUST_USE_RESULT Status ExecuteJob();
 
   // Finalizes the compile job. Must be called on the main thread.
   MUST_USE_RESULT Status FinalizeJob();
@@ skipping 11 matching lines @@
 
   virtual bool can_execute_on_background_thread() const { return true; }
 
   void set_stack_limit(uintptr_t stack_limit) { stack_limit_ = stack_limit; }
   uintptr_t stack_limit() const { return stack_limit_; }
 
   State state() const { return state_; }
   CompilationInfo* info() const { return info_; }
   Isolate* isolate() const;
 
+  // Destroy the CompilationInfo, its ParseInfo, and its zone at the end of
+  // this CompilationJob's lifetime.
+  void TakeOwnershipOfCompilationInfo();
+
  protected:
   // Overridden by the actual implementation.
   virtual Status PrepareJobImpl() = 0;
   virtual Status ExecuteJobImpl() = 0;
   virtual Status FinalizeJobImpl() = 0;
 
   // Registers weak object to optimized code dependencies.
   // TODO(turbofan): Move this to pipeline.cc once Crankshaft dies.
   void RegisterWeakObjectsInOptimizedCode(Handle<Code> code);
 
  private:
+  // The following unique_ptr are used only for lifetime management and might
+  // be empty.
+  std::unique_ptr<Zone> zone_;
+  std::unique_ptr<ParseInfo> parse_info_;
+  std::unique_ptr<CompilationInfo> compilation_info_;
+
   CompilationInfo* info_;
   base::TimeDelta time_taken_to_prepare_;
   base::TimeDelta time_taken_to_execute_;
   base::TimeDelta time_taken_to_finalize_;
   const char* compiler_name_;
   State state_;
   uintptr_t stack_limit_;
 
   MUST_USE_RESULT Status UpdateState(Status status, State next_state) {
     if (status == SUCCEEDED) {
       state_ = next_state;
     } else {
       state_ = State::kFailed;
     }
     return status;
   }
+
+  DISALLOW_COPY_AND_ASSIGN(CompilationJob);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_H_