Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 37698dd8f298b081a13d35fa3c6dec1f53fb0a1c..5045c23394532ba81989eb5d60159bdb40c1eaf2 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -33,7 +33,6 @@
#include "WebIconURL.h"
#include "WebNode.h"
-#include "WebURLLoaderOptions.h"
#include "public/platform/WebCanvas.h"
#include "public/platform/WebInsecureRequestPolicy.h"
#include "public/web/WebFrameLoadType.h"
@@ -56,6 +55,8 @@ namespace blink {
class Frame;
class OpenedFrameTracker;
class Visitor;
+class WebAssociatedURLLoader;
+struct WebAssociatedURLLoaderOptions;
class WebDOMEvent;
class WebData;
class WebDataSource;
@@ -70,7 +71,6 @@ class WebSecurityOrigin;
class WebSharedWorkerRepositoryClient;
class WebString;
class WebURL;
-class WebURLLoader;
class WebURLRequest;
class WebView;
enum class WebSandboxFlags;
@@ -381,11 +381,13 @@ class WebFrame {
// DEPRECATED: Please use createAssociatedURLLoader instead.
virtual void dispatchWillSendRequest(WebURLRequest&) = 0;
- // Returns a WebURLLoader that is associated with this frame. The loader
- // will, for example, be cancelled when WebFrame::stopLoading is called.
+ // Returns an AssociatedURLLoader that is associated with this frame. The
+ // loader will, for example, be cancelled when WebFrame::stopLoading is
+ // called.
+ //
// FIXME: stopLoading does not yet cancel an associated loader!!
- virtual WebURLLoader* createAssociatedURLLoader(
- const WebURLLoaderOptions& = WebURLLoaderOptions()) = 0;
+ virtual WebAssociatedURLLoader* createAssociatedURLLoader(
+ const WebAssociatedURLLoaderOptions&) = 0;
// Returns the number of registered unload listeners.
virtual unsigned unloadListenerCount() const = 0;
« no previous file with comments | « third_party/WebKit/public/web/WebAssociatedURLLoaderOptions.h ('k') | third_party/WebKit/public/web/WebURLLoaderOptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698