third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index da344b61042f78396536705321d4a022308a7443..9e1171988125dc51966ea8542e0e71df8278d26d 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -283,8 +283,8 @@ void WebRemoteFrameImpl::dispatchWillSendRequest(WebURLRequest&) {

NOTREACHED();

}

-WebURLLoader* WebRemoteFrameImpl::createAssociatedURLLoader(

- const WebURLLoaderOptions&) {

+WebAssociatedURLLoader* WebRemoteFrameImpl::createAssociatedURLLoader(

+ const WebAssociatedURLLoaderOptions&) {

NOTREACHED();

return nullptr;

}