Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: content/public/renderer/resource_fetcher.h

Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/associated_resource_fetcher.h ('k') | content/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/resource_fetcher.h
diff --git a/content/public/renderer/resource_fetcher.h b/content/public/renderer/resource_fetcher.h
index 71a12c4c7adfeb47bf50dbbbb70c8f1ae80853f3..9b897651ef5539e6cb7d9a6f177e1849f8bfa6d3 100644
--- a/content/public/renderer/resource_fetcher.h
+++ b/content/public/renderer/resource_fetcher.h
@@ -20,8 +20,6 @@ class TimeDelta;
namespace blink {
class WebFrame;
class WebURLResponse;
-enum class WebCachePolicy;
-struct WebURLLoaderOptions;
}
namespace content {
@@ -29,11 +27,6 @@ namespace content {
// Interface to download resources asynchronously.
class CONTENT_EXPORT ResourceFetcher {
public:
- enum LoaderType {
- PLATFORM_LOADER, // uses Platform::createURLLoader
- FRAME_ASSOCIATED_LOADER, // uses WebFrame::createAssociatedURLLoader
- };
-
virtual ~ResourceFetcher() {}
// This will be called asynchronously after the URL has been fetched,
@@ -55,20 +48,12 @@ class CONTENT_EXPORT ResourceFetcher {
virtual void SetBody(const std::string& body) = 0;
virtual void SetHeader(const std::string& header,
const std::string& value) = 0;
- virtual void SetSkipServiceWorker(
- blink::WebURLRequest::SkipServiceWorker skip_service_worker) = 0;
- virtual void SetCachePolicy(blink::WebCachePolicy policy) = 0;
-
- // Associate the corresponding WebURLLoaderOptions to the loader. Must be
- // called before Start. Used if the LoaderType is FRAME_ASSOCIATED_LOADER.
- virtual void SetLoaderOptions(const blink::WebURLLoaderOptions& options) = 0;
// Starts the request using the specified frame. Calls |callback| when
// done.
virtual void Start(blink::WebFrame* frame,
blink::WebURLRequest::RequestContext request_context,
blink::WebURLRequest::FrameType frame_type,
- LoaderType loader_type,
const Callback& callback) = 0;
// Sets how long to wait for the server to reply. By default, there is no
« no previous file with comments | « content/public/renderer/associated_resource_fetcher.h ('k') | content/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698