third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader (Closed)

Patch Set: Remove blank line Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 4bd3bdce4c842217a659d4a8bbe73cdeedee763e..21664a24206e3fa3fbf6f9b1166a0561495336f4 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -188,6 +188,7 @@

#include "public/platform/WebSuspendableTask.h"

#include "public/platform/WebURLError.h"

#include "public/platform/WebVector.h"

+#include "public/web/WebAssociatedURLLoaderOptions.h"

#include "public/web/WebAutofillClient.h"

#include "public/web/WebConsoleMessage.h"

#include "public/web/WebDOMEvent.h"

@@ -210,13 +211,13 @@

#include "public/web/WebSerializedScriptValue.h"

#include "public/web/WebTreeScopeType.h"

#include "skia/ext/platform_canvas.h"

-#include "web/AssociatedURLLoader.h"

#include "web/CompositionUnderlineVectorBuilder.h"

#include "web/FindInPageCoordinates.h"

#include "web/RemoteFrameOwner.h"

#include "web/SharedWorkerRepositoryClientImpl.h"

#include "web/SuspendableScriptExecutor.h"

#include "web/TextFinder.h"

+#include "web/WebAssociatedURLLoaderImpl.h"

#include "web/WebDataSourceImpl.h"

#include "web/WebDevToolsAgentImpl.h"

#include "web/WebFrameWidgetImpl.h"

@@ -952,9 +953,9 @@ void WebLocalFrameImpl::dispatchWillSendRequest(WebURLRequest& request) {

request.toMutableResourceRequest());

}

-WebURLLoader* WebLocalFrameImpl::createAssociatedURLLoader(

- const WebURLLoaderOptions& options) {

- return new AssociatedURLLoader(this, options);

+WebAssociatedURLLoader* WebLocalFrameImpl::createAssociatedURLLoader(

+ const WebAssociatedURLLoaderOptions& options) {

+ return new WebAssociatedURLLoaderImpl(this, options);

}

unsigned WebLocalFrameImpl::unloadListenerCount() const {