Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2399463007: AssociatedURLLoader shouldn't derive from WebURLLoader (Closed)
Patch Set: Addressed #38 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« content/renderer/fetchers/resource_fetcher_impl.cc ('K') | « third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 namespace blink { 49 namespace blink {
50 50
51 class ChromePrintContext; 51 class ChromePrintContext;
52 class IntSize; 52 class IntSize;
53 class KURL; 53 class KURL;
54 class Range; 54 class Range;
55 class ScrollableArea; 55 class ScrollableArea;
56 class SharedWorkerRepositoryClientImpl; 56 class SharedWorkerRepositoryClientImpl;
57 class TextFinder; 57 class TextFinder;
58 class WebAssociatedURLLoader;
59 struct WebAssociatedURLLoaderOptions;
58 class WebAutofillClient; 60 class WebAutofillClient;
59 class WebDataSourceImpl; 61 class WebDataSourceImpl;
60 class WebDevToolsAgentImpl; 62 class WebDevToolsAgentImpl;
61 class WebDevToolsFrontendImpl; 63 class WebDevToolsFrontendImpl;
62 class WebFrameClient; 64 class WebFrameClient;
63 class WebNode; 65 class WebNode;
64 class WebPerformance; 66 class WebPerformance;
65 class WebPlugin; 67 class WebPlugin;
66 class WebPluginContainerImpl; 68 class WebPluginContainerImpl;
67 class WebScriptExecutionCallback; 69 class WebScriptExecutionCallback;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 const WebURL& baseURL, 155 const WebURL& baseURL,
154 const WebURL& unreachableURL, 156 const WebURL& unreachableURL,
155 bool replace) override; 157 bool replace) override;
156 void stopLoading() override; 158 void stopLoading() override;
157 WebDataSource* provisionalDataSource() const override; 159 WebDataSource* provisionalDataSource() const override;
158 WebDataSource* dataSource() const override; 160 WebDataSource* dataSource() const override;
159 void enableViewSourceMode(bool enable) override; 161 void enableViewSourceMode(bool enable) override;
160 bool isViewSourceModeEnabled() const override; 162 bool isViewSourceModeEnabled() const override;
161 void setReferrerForRequest(WebURLRequest&, const WebURL& referrer) override; 163 void setReferrerForRequest(WebURLRequest&, const WebURL& referrer) override;
162 void dispatchWillSendRequest(WebURLRequest&) override; 164 void dispatchWillSendRequest(WebURLRequest&) override;
163 WebURLLoader* createAssociatedURLLoader(const WebURLLoaderOptions&) override; 165 WebAssociatedURLLoader* createAssociatedURLLoader(
166 const WebAssociatedURLLoaderOptions&) override;
164 unsigned unloadListenerCount() const override; 167 unsigned unloadListenerCount() const override;
165 void setMarkedText(const WebString&, 168 void setMarkedText(const WebString&,
166 unsigned location, 169 unsigned location,
167 unsigned length) override; 170 unsigned length) override;
168 void unmarkText() override; 171 void unmarkText() override;
169 bool hasMarkedText() const override; 172 bool hasMarkedText() const override;
170 WebRange markedRange() const override; 173 WebRange markedRange() const override;
171 bool firstRectForCharacterRange(unsigned location, 174 bool firstRectForCharacterRange(unsigned location,
172 unsigned length, 175 unsigned length,
173 WebRect&) const override; 176 WebRect&) const override;
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 476
474 DEFINE_TYPE_CASTS(WebLocalFrameImpl, 477 DEFINE_TYPE_CASTS(WebLocalFrameImpl,
475 WebFrame, 478 WebFrame,
476 frame, 479 frame,
477 frame->isWebLocalFrame(), 480 frame->isWebLocalFrame(),
478 frame.isWebLocalFrame()); 481 frame.isWebLocalFrame());
479 482
480 } // namespace blink 483 } // namespace blink
481 484
482 #endif 485 #endif
OLDNEW
« content/renderer/fetchers/resource_fetcher_impl.cc ('K') | « third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698