|
|
Chromium Code Reviews
DescriptionUse FileDescriptorWatcher in signal_handler.cc.
This allows RegisterSignalHandler to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.
BUG=645114
Committed: https://crrev.com/aae14a15971bc8f64e591593bbe626b44839993a
Cr-Commit-Position: refs/heads/master@{#424472}
Patch Set 1 #Patch Set 2 : fix build error #Patch Set 3 : fix build error #Messages
Total messages: 22 (16 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + joedow@chromium.org
PTAL
joedow@chromium.org changed reviewers: + jamiewalch@chromium.org
I'm not that familiar with this file, Jamie would be a better person to look at this change.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use FileDescriptorWatcher in signal_handler.cc. This allows RegisterSignalHandler to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 ========== to ========== Use FileDescriptorWatcher in signal_handler.cc. This allows RegisterSignalHandler to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/aae14a15971bc8f64e591593bbe626b44839993a Cr-Commit-Position: refs/heads/master@{#424472} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/aae14a15971bc8f64e591593bbe626b44839993a Cr-Commit-Position: refs/heads/master@{#424472} |
