Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2399463003: Use FileDescriptorWatcher in signal_handler.cc. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Jamie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in signal_handler.cc. This allows RegisterSignalHandler to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/aae14a15971bc8f64e591593bbe626b44839993a Cr-Commit-Position: refs/heads/master@{#424472}

Patch Set 1 #

Patch Set 2 : fix build error #

Patch Set 3 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M remoting/host/posix/signal_handler.cc View 1 2 4 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-07 17:22:41 UTC) #14
joedow
I'm not that familiar with this file, Jamie would be a better person to look ...
4 years, 2 months ago (2016-10-11 16:53:45 UTC) #16
Jamie
lgtm
4 years, 2 months ago (2016-10-11 17:02:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399463003/40001
4 years, 2 months ago (2016-10-11 17:05:45 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 17:33:31 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:35:01 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aae14a15971bc8f64e591593bbe626b44839993a
Cr-Commit-Position: refs/heads/master@{#424472}

Powered by Google App Engine
This is Rietveld 408576698