Clear mojo URLLoaderClient in ResourceDispatcher on cancellation

content/child/resource_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/child/resource_dispatcher.h"
 
 #include <utility>
 
@@ skipping 435 matching lines @@
   PendingRequestMap::iterator it = pending_requests_.find(request_id);
   if (it == pending_requests_.end())
     return false;
 
   PendingRequestInfo* request_info = it->second.get();
 
   bool release_downloaded_file = request_info->download_to_file;
 
   ReleaseResourcesInMessageQueue(&request_info->deferred_message_queue);
 
+  if (it->second->url_loader_client)
+    it->second->url_loader_client = nullptr;

[yhirano, 2016/10/05 09:03:00]

Would Calling Cancel be enough?

[tzik, 2016/10/06 04:14:02]

As we chatted offline, URLLoaderClient (and URLLoaderClientImpl) doesn't have
Cancel(), and I think it's less cleaner to implement it, since we'll have to
care a IPC message arrival after the cancellation.

[yhirano, 2016/10/06 06:53:05]

Can you run this statement unconditionally?

[tzik, 2016/10/06 12:08:13]

Done.

+
   // Always delete the pending_request asyncly so that cancelling the request
   // doesn't delete the request context info while its response is still being
   // handled.
   main_thread_task_runner_->DeleteSoon(FROM_HERE, it->second.release());
   pending_requests_.erase(it);
 
   if (release_downloaded_file) {
     message_sender_->Send(
         new ResourceHostMsg_ReleaseDownloadedFile(request_id));
   }
@@ skipping 344 matching lines @@
     delete message;
   }
 }
 
 void ResourceDispatcher::SetResourceSchedulingFilter(
     scoped_refptr<ResourceSchedulingFilter> resource_scheduling_filter) {
   resource_scheduling_filter_ = resource_scheduling_filter;
 }
 
 }  // namespace content