Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2399443002: Prune createVisibleSelectionDeprecated from FocusController (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from FocusController BUG=651373 Committed: https://crrev.com/7562d689d633f658704e81899e5a86a4a6375b8d Cr-Commit-Position: refs/heads/master@{#423100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL. Last time I added a layout update but forgot to change createVisibleSelectionDeprecated to createVisibleSelection...
4 years, 2 months ago (2016-10-05 07:18:49 UTC) #4
tkent
lgtm
4 years, 2 months ago (2016-10-05 07:28:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399443002/1
4 years, 2 months ago (2016-10-05 07:33:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 07:38:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 07:39:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7562d689d633f658704e81899e5a86a4a6375b8d
Cr-Commit-Position: refs/heads/master@{#423100}

Powered by Google App Engine
This is Rietveld 408576698