Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2399433002:
[DO NOT COMMIT] oilpan clang check (Closed)
|
Created:
4 years, 2 months ago by yhirano Modified:
4 years, 2 months ago Reviewers:
oilpan-reviews CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DO NOT COMMIT] oilpan clang check
wip
BUG=
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
yhirano@chromium.org changed reviewers: + oilpan-reviews@chromium.org
Hi oilpan-reviews@, can you take a look at this CL? I think this CL should be compiled but it's not. Please correct me if I'm wrong.
On 2016/10/05 04:00:11, yhirano wrote: > Hi oilpan-reviews@, can you take a look at this CL? I think this CL should be > compiled but it's not. Please correct me if I'm wrong. What error are you hitting?
On 2016/10/05 04:13:58, haraken wrote:
> On 2016/10/05 04:00:11, yhirano wrote:
> > Hi oilpan-reviews@, can you take a look at this CL? I think this CL should
be
> > compiled but it's not. Please correct me if I'm wrong.
>
> What error are you hitting?
../../third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:78:3:
error: [blink-gc] Base class 'X' of derived class 'Y<blink::(anonymous
namespace)::X>' requires tracing.
DEFINE_INLINE_TRACE() { T::trace(visitor); }
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:129:31: note: expanded
from macro 'DEFINE_INLINE_TRACE'
#define DEFINE_INLINE_TRACE() DEFINE_INLINE_TRACE_IMPL(EMPTY_MACRO_ARGUMENT)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:92:3: note: expanded
from macro 'DEFINE_INLINE_TRACE_IMPL'
inline void traceImpl(VisitorDispatcher visitor)
^
1 error generated.
On 2016/10/05 04:18:57, yhirano wrote:
> On 2016/10/05 04:13:58, haraken wrote:
> > On 2016/10/05 04:00:11, yhirano wrote:
> > > Hi oilpan-reviews@, can you take a look at this CL? I think this CL should
> be
> > > compiled but it's not. Please correct me if I'm wrong.
> >
> > What error are you hitting?
>
> ../../third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:78:3:
> error: [blink-gc] Base class 'X' of derived class 'Y<blink::(anonymous
> namespace)::X>' requires tracing.
> DEFINE_INLINE_TRACE() { T::trace(visitor); }
> ^
> ../../third_party/WebKit/Source/platform/heap/Visitor.h:129:31: note: expanded
> from macro 'DEFINE_INLINE_TRACE'
> #define DEFINE_INLINE_TRACE() DEFINE_INLINE_TRACE_IMPL(EMPTY_MACRO_ARGUMENT)
> ^
> ../../third_party/WebKit/Source/platform/heap/Visitor.h:92:3: note: expanded
> from macro 'DEFINE_INLINE_TRACE_IMPL'
> inline void traceImpl(VisitorDispatcher visitor)
> ^
> 1 error generated.
Thanks.
Would you suppress the error with GC_PLUGIN_IGNORE for now? It's not likely that
we can have time to fix the clang plugin for complicated template patterns.
On 2016/10/05 04:22:52, haraken wrote:
> On 2016/10/05 04:18:57, yhirano wrote:
> > On 2016/10/05 04:13:58, haraken wrote:
> > > On 2016/10/05 04:00:11, yhirano wrote:
> > > > Hi oilpan-reviews@, can you take a look at this CL? I think this CL
should
> > be
> > > > compiled but it's not. Please correct me if I'm wrong.
> > >
> > > What error are you hitting?
> >
> > ../../third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:78:3:
> > error: [blink-gc] Base class 'X' of derived class 'Y<blink::(anonymous
> > namespace)::X>' requires tracing.
> > DEFINE_INLINE_TRACE() { T::trace(visitor); }
> > ^
> > ../../third_party/WebKit/Source/platform/heap/Visitor.h:129:31: note:
expanded
> > from macro 'DEFINE_INLINE_TRACE'
> > #define DEFINE_INLINE_TRACE() DEFINE_INLINE_TRACE_IMPL(EMPTY_MACRO_ARGUMENT)
> > ^
> > ../../third_party/WebKit/Source/platform/heap/Visitor.h:92:3: note: expanded
> > from macro 'DEFINE_INLINE_TRACE_IMPL'
> > inline void traceImpl(VisitorDispatcher visitor)
> > ^
> > 1 error generated.
>
> Thanks.
>
> Would you suppress the error with GC_PLUGIN_IGNORE for now? It's not likely
that
> we can have time to fix the clang plugin for complicated template patterns.
Sure.
Description was changed from ========== [DO NOT COMMIT] oilpan clang check wip BUG= ========== to ========== [DO NOT COMMIT] oilpan clang check wip BUG= ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
