Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/bootstrapper.cc

Issue 2399423003: [builtins] Move StringIncludes to a builtin. (Closed)
Patch Set: Add another test. Re-use IsRegExp logic Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1419 matching lines...) Expand 10 before | Expand all | Expand 10 after
1430 1430
1431 // Install the "constructor" property on the {prototype}. 1431 // Install the "constructor" property on the {prototype}.
1432 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun, 1432 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun,
1433 DONT_ENUM); 1433 DONT_ENUM);
1434 1434
1435 // Install the String.prototype methods. 1435 // Install the String.prototype methods.
1436 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt, 1436 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt,
1437 1, true); 1437 1, true);
1438 SimpleInstallFunction(prototype, "charCodeAt", 1438 SimpleInstallFunction(prototype, "charCodeAt",
1439 Builtins::kStringPrototypeCharCodeAt, 1, true); 1439 Builtins::kStringPrototypeCharCodeAt, 1, true);
1440 SimpleInstallFunction(prototype, "includes",
1441 Builtins::kStringPrototypeIncludes, 1, false);
1440 SimpleInstallFunction(prototype, "indexOf", 1442 SimpleInstallFunction(prototype, "indexOf",
1441 Builtins::kStringPrototypeIndexOf, 1, false); 1443 Builtins::kStringPrototypeIndexOf, 1, false);
1442 SimpleInstallFunction(prototype, "lastIndexOf", 1444 SimpleInstallFunction(prototype, "lastIndexOf",
1443 Builtins::kStringPrototypeLastIndexOf, 1, false); 1445 Builtins::kStringPrototypeLastIndexOf, 1, false);
1444 SimpleInstallFunction(prototype, "localeCompare", 1446 SimpleInstallFunction(prototype, "localeCompare",
1445 Builtins::kStringPrototypeLocaleCompare, 1, true); 1447 Builtins::kStringPrototypeLocaleCompare, 1, true);
1446 SimpleInstallFunction(prototype, "normalize", 1448 SimpleInstallFunction(prototype, "normalize",
1447 Builtins::kStringPrototypeNormalize, 0, false); 1449 Builtins::kStringPrototypeNormalize, 0, false);
1448 SimpleInstallFunction(prototype, "substr", Builtins::kStringPrototypeSubstr, 1450 SimpleInstallFunction(prototype, "substr", Builtins::kStringPrototypeSubstr,
1449 2, true); 1451 2, true);
(...skipping 2903 matching lines...) Expand 10 before | Expand all | Expand 10 after
4353 } 4355 }
4354 4356
4355 4357
4356 // Called when the top-level V8 mutex is destroyed. 4358 // Called when the top-level V8 mutex is destroyed.
4357 void Bootstrapper::FreeThreadResources() { 4359 void Bootstrapper::FreeThreadResources() {
4358 DCHECK(!IsActive()); 4360 DCHECK(!IsActive());
4359 } 4361 }
4360 4362
4361 } // namespace internal 4363 } // namespace internal
4362 } // namespace v8 4364 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698