Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2399413003: Run BrowserThreadTest.RunsTasksOnCurrentThreadDuringShutdown on UI thread. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run BrowserThreadTest.RunsTasksOnCurrentThreadDuringShutdown on UI thread. In preparation for the migration of the FILE thread to TaskScheduler, we want to disable destruction observers on it. BrowserThreadTest.RunsTasksOnCurrentThreadDuringShutdown is the only test that fails when destruction observers are disabled on the FILE thread. This CL changes this test to use the UI thread instead. BUG=653916 Committed: https://crrev.com/f854c913531ac6ed65459c367070aad07179d531 Cr-Commit-Position: refs/heads/master@{#424151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M content/browser/browser_thread_unittest.cc View 6 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-07 20:31:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-10 12:45:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399413003/1
4 years, 2 months ago (2016-10-10 14:19:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 14:51:27 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:53:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f854c913531ac6ed65459c367070aad07179d531
Cr-Commit-Position: refs/heads/master@{#424151}

Powered by Google App Engine
This is Rietveld 408576698