Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 23994004: Prepare push to trunk. Now working on version 3.21.14. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.21.14. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16633

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 3 months ago (2013-09-11 08:03:36 UTC) #1
Yang
https://codereview.chromium.org/23994004/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/23994004/diff/1/ChangeLog#newcode8 ChangeLog:8: Remove HandleScope default ctor. I don't think this belongs ...
7 years, 3 months ago (2013-09-11 08:15:51 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/23994004/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/23994004/diff/1/ChangeLog#newcode8 ChangeLog:8: Remove HandleScope default ctor. On 2013/09/11 08:15:51, Yang wrote: ...
7 years, 3 months ago (2013-09-11 08:22:00 UTC) #3
Yang
On 2013/09/11 08:22:00, Hannes Payer wrote: > https://codereview.chromium.org/23994004/diff/1/ChangeLog > File ChangeLog (right): > > https://codereview.chromium.org/23994004/diff/1/ChangeLog#newcode8 ...
7 years, 3 months ago (2013-09-11 08:22:24 UTC) #4
Hannes Payer (out of office)
7 years, 3 months ago (2013-09-11 08:23:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698