Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2399333003: DBC: Support large offsets in optimized field access. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Support large offsets in optimized field access. Added two new bytecodes: LoadFieldExt, StoreFieldExt that store the field offset in the following nop-instruction that is skipped. This allows offsets up to 16 bit. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/a292de544f69b8b76a7de9130e9d8ddb95588e99

Patch Set 1 #

Patch Set 2 : update comment #

Total comments: 2

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
M runtime/vm/constants_dbc.h View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 2 chunks +24 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 2 months ago (2016-10-07 20:32:30 UTC) #2
zra
lgtm with nit https://codereview.chromium.org/2399333003/diff/20001/runtime/vm/simulator_dbc.cc File runtime/vm/simulator_dbc.cc (right): https://codereview.chromium.org/2399333003/diff/20001/runtime/vm/simulator_dbc.cc#newcode2383 runtime/vm/simulator_dbc.cc:2383: RawObject* value = reinterpret_cast<RawObject*>(FP[rD]); FP is ...
4 years, 2 months ago (2016-10-07 20:43:16 UTC) #3
Florian Schneider
https://codereview.chromium.org/2399333003/diff/20001/runtime/vm/simulator_dbc.cc File runtime/vm/simulator_dbc.cc (right): https://codereview.chromium.org/2399333003/diff/20001/runtime/vm/simulator_dbc.cc#newcode2383 runtime/vm/simulator_dbc.cc:2383: RawObject* value = reinterpret_cast<RawObject*>(FP[rD]); On 2016/10/07 20:43:16, zra wrote: ...
4 years, 2 months ago (2016-10-07 20:57:19 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-07 21:03:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a292de544f69b8b76a7de9130e9d8ddb95588e99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698