Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4719)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2399233002: Add histograms to the rendez-vous process (ProcessSingleton). (Closed)
Patch Set: +comment about lacking fast notification path timing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/process_singleton.h » ('j') | chrome/browser/process_singleton.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index c23936ba25af2a4ed92a0086711e7e14a9b440eb..148940205e343b8b41e30393a43b2548c938c7ab 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1646,6 +1646,9 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
// 20 seconds to respond. Note that this needs to be done before we attempt
// to read the profile.
notify_result_ = process_singleton_->NotifyOtherProcessOrCreate();
+ UMA_HISTOGRAM_ENUMERATION("Chrome.ProcessSingleton.NotifyResult",
+ notify_result_,
+ ProcessSingleton::NUM_NOTIFY_RESULTS);
switch (notify_result_) {
case ProcessSingleton::PROCESS_NONE:
// No process already running, fall through to starting a new one.
@@ -1679,8 +1682,9 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
"now to avoid profile corruption.";
return chrome::RESULT_CODE_PROFILE_IN_USE;
- default:
+ case ProcessSingleton::NUM_NOTIFY_RESULTS:
bcwhite 2016/10/07 16:17:44 Why this change?
gab 2016/10/07 16:34:14 Because it's better to enumerate all cases than to
bcwhite 2016/10/07 16:59:45 Acknowledged.
NOTREACHED();
+ break;
}
#endif // !defined(OS_ANDROID)
« no previous file with comments | « no previous file | chrome/browser/process_singleton.h » ('j') | chrome/browser/process_singleton.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698