Issue 239923004: Allow merging of monomorphic accesses to tracked fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239923004: Allow merging of monomorphic accesses to tracked fields. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow merging of monomorphic accesses to tracked fields. Also add stability dependency only on maps that can transition, and delay adding the dependencies until we are actually using them, either in a HLoadNamedField or an HCheckMaps. TEST=mjsunit/field-type-tracking R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20796

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style fix. #

Patch Set 3 : Add comment. #

Patch Set 4 : Add test case for merging of monomorphic loads. #

Patch Set 5 : REBASE #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -40 lines)			Patch
M	src/hydrogen.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4	6 chunks	+54 lines, -26 lines	0 comments	Download
M	src/hydrogen-check-elimination.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		5 chunks	+20 lines, -6 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	test/mjsunit/field-type-tracking.js	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

PTAL https://codereview.chromium.org/239923004/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/239923004/diff/1/src/hydrogen.cc#newcode5421 src/hydrogen.cc:5421: // TODO(bmeurer): Also apply stable maps optimization to ...

6 years, 8 months ago (2014-04-16 07:35:24 UTC) #1

Benedikt Meurer

6 years, 8 months ago (2014-04-16 11:41:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r20796 (presubmit successful).

Expand Messages | Collapse Messages