Chromium Code Reviews

Issue 239923004: Allow merging of monomorphic accesses to tracked fields. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Allow merging of monomorphic accesses to tracked fields. Also add stability dependency only on maps that can transition, and delay adding the dependencies until we are actually using them, either in a HLoadNamedField or an HCheckMaps. TEST=mjsunit/field-type-tracking R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20796

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style fix. #

Patch Set 3 : Add comment. #

Patch Set 4 : Add test case for merging of monomorphic loads. #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Stats (+105 lines, -40 lines)
M src/hydrogen.h View 2 chunks +4 lines, -3 lines 0 comments
M src/hydrogen.cc View 6 chunks +54 lines, -26 lines 0 comments
M src/hydrogen-check-elimination.cc View 1 chunk +3 lines, -3 lines 0 comments
M src/hydrogen-instructions.h View 5 chunks +20 lines, -6 lines 0 comments
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -2 lines 0 comments
M test/mjsunit/field-type-tracking.js View 1 chunk +18 lines, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL https://codereview.chromium.org/239923004/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/239923004/diff/1/src/hydrogen.cc#newcode5421 src/hydrogen.cc:5421: // TODO(bmeurer): Also apply stable maps optimization to ...
6 years, 8 months ago (2014-04-16 07:35:24 UTC) #1
Sven Panne
lgtm
6 years, 8 months ago (2014-04-16 07:48:45 UTC) #2
Benedikt Meurer
6 years, 8 months ago (2014-04-16 11:41:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r20796 (presubmit successful).

Powered by Google App Engine