Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2399203003:
Always use FinalizeUnoptimizedCompilationJob (Closed)
|
Created:
4 years, 2 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAlways use FinalizeUnoptimizedCompilationJob
Before, some code paths just invoked job->FinalizeJob() and then
manually installed the compilation result. Unify these.
BUG=v8:5394
R=mstarzinger@chromium.org
Committed: https://crrev.com/879fac3b56e8ada73a7490d48696cdcf36b95061
Cr-Commit-Position: refs/heads/master@{#40120}
Patch Set 1 #
Total comments: 2
Patch Set 2 : updates #Patch Set 3 : updates #
Dependent Patchsets: Messages
Total messages: 24 (15 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2399203003/diff/1/src/compiler.cc File src/compiler.cc (left): https://codereview.chromium.org/2399203003/diff/1/src/compiler.cc#oldcode1131 src/compiler.cc:1131: PROFILE(isolate, CodeCreateEvent(log_tag, result->abstract_code(), *result, This seems to be firing multiple code creation events now. One with the LAZY_COMPILE_TAG tag during the job finalization and one here with the correct tag. https://codereview.chromium.org/2399203003/diff/1/src/compiler.cc#oldcode1788 src/compiler.cc:1788: RecordFunctionCompilation(CodeEventListener::FUNCTION_TAG, &info); Likewise, multiple code creation events firing.
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I moved the RecordFunctionCompilation call form InstallUnoptimizedCode to GetUnoptimizedCode and FinalizeCompilationJob, so I think there are no longer code paths with duplicate events ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jochen@chromium.org changed reviewers: + yangguo@chromium.org
+yang
On 2016/10/10 09:22:54, jochen wrote: > I moved the RecordFunctionCompilation call form InstallUnoptimizedCode to > GetUnoptimizedCode and FinalizeCompilationJob, so I think there are no longer > code paths with duplicate events > > ptal lgtm.
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Always use FinalizeUnoptimizedCompilationJob Before, some code paths just invoked job->FinalizeJob() and then manually installed the compilation result. Unify these. BUG=v8:5394 R=mstarzinger@chromium.org ========== to ========== Always use FinalizeUnoptimizedCompilationJob Before, some code paths just invoked job->FinalizeJob() and then manually installed the compilation result. Unify these. BUG=v8:5394 R=mstarzinger@chromium.org Committed: https://crrev.com/879fac3b56e8ada73a7490d48696cdcf36b95061 Cr-Commit-Position: refs/heads/master@{#40120} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/879fac3b56e8ada73a7490d48696cdcf36b95061 Cr-Commit-Position: refs/heads/master@{#40120} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
