blob hacking webcore style

LayoutTests/fast/storage/resources/serialized-script-value.js

Index: LayoutTests/fast/storage/resources/serialized-script-value.js
diff --git a/LayoutTests/fast/storage/resources/serialized-script-value.js b/LayoutTests/fast/storage/resources/serialized-script-value.js
index 48731e85f5ded40d6e26e811aefe00240dde90c0..b5b150752857f378668846a00fb1d7cacff3b7ce 100644
--- a/LayoutTests/fast/storage/resources/serialized-script-value.js
+++ b/LayoutTests/fast/storage/resources/serialized-script-value.js
@@ -93,3 +93,13 @@ function _testSerialization(bytesPerElement, obj, values, oldFormat, serializeEx
     }
     expectBufferValue(bytesPerElement, values, serialized);
 }
+
+function _testBlobSerialization() {

[kinuko, 2013/10/02 15:41:39]

nit: Unlike _testSerialization we're calling this function without any
indirection in .html... I doubt we need preceding '_' in this function name.

[michaeln, 2013/10/02 20:09:01]

Do you know the reasons for that layer of indirection in the .html for
_testSerialization?

+    debug("");
+    self.blobObj1 = new Blob(['Hi'], {type: 'text/plain'});
+    self.blobObj2 = internals.deserializeBuffer(internals.serializeObject(blobObj1));
+    shouldBeTrue("areValuesIdentical(blobObj1, blobObj2)");

[kinuko, 2013/10/02 15:41:39]

areValuesIdentical only checks object properties, and for Blob it's only 'size'
and 'type'.  I feel ideally we should have a test which checks its contents too

[michaeln, 2013/10/02 20:09:01]

i could use sync xhr with public blob urls to test the contents without making
the test async

[michaeln, 2013/10/02 20:30:40]

Done.

+    self.dictionaryWithBlob1 = {blob: blobObj1, string: 'stringValue'};
+    self.dictionaryWithBlob2 = internals.deserializeBuffer(internals.serializeObject(dictionaryWithBlob1));
+    shouldBeTrue("areValuesIdentical(dictionaryWithBlob1, dictionaryWithBlob2)");
+}