blob hacking webcore style

Source/modules/websockets/NewWebSocketChannelImpl.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 54 matching lines @@
         return adoptRef(new NewWebSocketChannelImpl(context, client, sourceURL, lineNumber));
     }
     virtual ~NewWebSocketChannelImpl();
 
     // WebSocketChannel functions.
     virtual void connect(const KURL&, const String& protocol) OVERRIDE;
     virtual String subprotocol() OVERRIDE;
     virtual String extensions() OVERRIDE;
     virtual WebSocketChannel::SendResult send(const String& message) OVERRIDE;
     virtual WebSocketChannel::SendResult send(const ArrayBuffer&, unsigned byteOffset, unsigned byteLength) OVERRIDE;
-    virtual WebSocketChannel::SendResult send(const Blob&) OVERRIDE;
+    virtual WebSocketChannel::SendResult send(PassRefPtr<BlobDataHandle>) OVERRIDE;
     virtual unsigned long bufferedAmount() const OVERRIDE;
     // Start closing handshake. Use the CloseEventCodeNotSpecified for the code
     // argument to omit payload.
     virtual void close(int code, const String& reason) OVERRIDE;
     virtual void fail(const String& reason, MessageLevel, const String&, unsigned lineNumber) OVERRIDE;
     using WebSocketChannel::fail;
     virtual void disconnect() OVERRIDE;
 
     using RefCounted<NewWebSocketChannelImpl>::ref;
     using RefCounted<NewWebSocketChannelImpl>::deref;
 
     virtual void suspend() OVERRIDE;
     virtual void resume() OVERRIDE;
 
     void handleDidConnect();
     void handleTextMessage(Vector<char>*);
     void handleBinaryMessage(Vector<char>*);
     void handleDidReceiveMessageError();
     void handleDidClose(unsigned short code, const String& reason);
 
 private:
     enum MessageType {
         MessageTypeText,
         MessageTypeBlob,
         MessageTypeArrayBuffer,
     };
 
     struct Message {
         explicit Message(const String&);
-        explicit Message(const Blob&);
+        explicit Message(PassRefPtr<BlobDataHandle>);
         explicit Message(PassRefPtr<ArrayBuffer>);
         MessageType type;
         CString text;
-        RefPtr<Blob> blob;
+        RefPtr<BlobDataHandle> blobData;

[kinuko, 2013/09/30 11:31:53]

nit: We also have a class named BlobData, and calling this (of BlobDataHandle)
'blobData' could be possibly confusing.. ?

[michaeln, 2013/09/30 20:50:24]

renamed to blobDataHandle

         RefPtr<ArrayBuffer> arrayBuffer;
     };
 
     struct ReceivedMessage {
         bool isMessageText;
         Vector<char> data;
     };
 
     class BlobLoader;
     class Resumer;
@@ skipping 43 matching lines @@
     size_t m_sentSizeOfTopMessage;
     String m_subprotocol;
     String m_extensions;
 
     static const int64_t receivedDataSizeForFlowControlHighWaterMark = 1 << 15;
 };
 
 } // namespace WebCore
 
 #endif // NewWebSocketChannelImpl_h