Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2399173002: Revert of DevTools: archive content shell (Closed)

Created:
4 years, 2 months ago by chenwilliam
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/1b4a4481659156b7395b59e2f5560f2245c84b08 Cr-Commit-Position: refs/heads/master@{#423687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -196 lines) Patch
M chrome/tools/build/linux/FILES.cfg View 1 chunk +1 line, -86 lines 0 comments Download
M chrome/tools/build/mac/FILES.cfg View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
chenwilliam
Created Revert of DevTools: archive content shell
4 years, 2 months ago (2016-10-06 20:40:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399173002/1
4 years, 2 months ago (2016-10-06 20:40:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 20:40:42 UTC) #5
kerz_google
lgtm
4 years, 2 months ago (2016-10-06 20:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399173002/1
4 years, 2 months ago (2016-10-06 20:52:15 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 20:52:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399173002/1
4 years, 2 months ago (2016-10-06 21:03:26 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 21:03:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399173002/1
4 years, 2 months ago (2016-10-06 21:05:02 UTC) #18
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 21:05:03 UTC) #20
kerz_chromium
lgtm
4 years, 2 months ago (2016-10-06 21:23:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399173002/1
4 years, 2 months ago (2016-10-06 21:24:52 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:27:47 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:29:45 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b4a4481659156b7395b59e2f5560f2245c84b08
Cr-Commit-Position: refs/heads/master@{#423687}

Powered by Google App Engine
This is Rietveld 408576698