|
|
Created:
4 years, 2 months ago by chenwilliam Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ )
Reason for revert:
This broke the chromium build archive crbug.com/653406
Original issue's description:
> DevTools: archive content shell
>
> Creates an archive of the content shell for each desktop platform.
> This will enable external contributors to use a precompiled
> content shell to run devtools layout tests (and possibly others).
>
> I manually verified these files are needed to run devtools layout tests
> with the content shell.
>
> BUG=none
>
> Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf
> Cr-Commit-Position: refs/heads/master@{#423195}
TBR=kerz@chromium.org,kerz@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
NOTRY=true
NOPRESUBMIT=true
Committed: https://crrev.com/1b4a4481659156b7395b59e2f5560f2245c84b08
Cr-Commit-Position: refs/heads/master@{#423687}
Patch Set 1 #
Messages
Total messages: 27 (13 generated)
The CQ bit was checked by chenwilliam@chromium.org
Created Revert of DevTools: archive content shell
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none ========== to ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true ==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true ========== to ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true ========== to ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true ========== to ========== Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: This broke the chromium build archive crbug.com/653406 Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > I manually verified these files are needed to run devtools layout tests > with the content shell. > > BUG=none > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Cr-Commit-Position: refs/heads/master@{#423195} TBR=kerz@chromium.org,kerz@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/1b4a4481659156b7395b59e2f5560f2245c84b08 Cr-Commit-Position: refs/heads/master@{#423687} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1b4a4481659156b7395b59e2f5560f2245c84b08 Cr-Commit-Position: refs/heads/master@{#423687} |