Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2399073002: Raise FD limit on Mac for simple cache backend performance. (Closed)

Created:
4 years, 2 months ago by gavinp
Modified:
4 years, 2 months ago
Reviewers:
clamy, jkarlin
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Raise FD limit on Mac for simple cache backend performance. The simple cache can use too many FDs and crash systems with low FD limits, like Macs. Longer term we should probably have ways to not keep so many files open simultaneously, but the quick fix is to raise the limit on Mac. R=jkarlin@chromium.org,clamy@chromium.org BUG=634413 Committed: https://crrev.com/a6fd373bc442e38505a782362514bd0ffbfeaf98 Cr-Commit-Position: refs/heads/master@{#423846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
gavinp
Note that base::SetFdLimit() saturates, so there's no need to look at the soft limits her ...
4 years, 2 months ago (2016-10-06 16:06:36 UTC) #3
clamy
Thanks! Lgtm.
4 years, 2 months ago (2016-10-07 11:07:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399073002/1
4 years, 2 months ago (2016-10-07 13:33:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 13:39:27 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 13:41:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6fd373bc442e38505a782362514bd0ffbfeaf98
Cr-Commit-Position: refs/heads/master@{#423846}

Powered by Google App Engine
This is Rietveld 408576698