PlzNavigate: make ServiceWorker ForeignFetch work

PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
Committed: https://crrev.com/37e10ddfe88bcf59a9f8065b16891ad0ae191f35
Cr-Commit-Position: refs/heads/master@{#423833}

[clamy, 2016-10-06 15:44:31]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-10-06 15:45:05]

Description was changed from

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
==========

to

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
==========

[clamy, 2016-10-06 15:45:05]

clamy@chromium.org changed reviewers:
+ falken@chromium.org, mmenke@chromium.org

[clamy, 2016-10-06 15:45:22]

@falken, mmenke: PTAL

[mmenke, 2016-10-06 15:50:48]

On 2016/10/06 15:45:22, clamy wrote:
> @falken, mmenke: PTAL

LGTM, rubberstamp, deferring to falken.

[commit-bot: I haz the power, 2016-10-06 16:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 16:53:54]

Dry run: This issue passed the CQ dry run.

[falken, 2016-10-07 03:49:32]

lgtm

https://codereview.chromium.org/2399063002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_request_info_impl.h (right):

https://codereview.chromium.org/2399063002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_request_info_impl.h:213:
ServiceWorkerContextWrapper* service_worker_context) {
nit: in modern Chromium style this should be a scoped_refptr:

"If the function (at least sometimes) takes a ref on a refcounted object,
declare the param as scoped_refptr<T>. The caller can decide whether it wishes
to transfer ownership (by calling std::move(t) when passing t) or retain its ref
(by simply passing t directly)."

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

[clamy, 2016-10-07 10:01:52]

Thanks!

https://codereview.chromium.org/2399063002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_request_info_impl.h (right):

https://codereview.chromium.org/2399063002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_request_info_impl.h:213:
ServiceWorkerContextWrapper* service_worker_context) {
On 2016/10/07 03:49:32, falken wrote:
> nit: in modern Chromium style this should be a scoped_refptr:
> 
> "If the function (at least sometimes) takes a ref on a refcounted object,
> declare the param as scoped_refptr<T>. The caller can decide whether it wishes
> to transfer ownership (by calling std::move(t) when passing t) or retain its
ref
> (by simply passing t directly)."
> 
> https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

Done.

[clamy, 2016-10-07 10:01:57]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-10-07 10:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2399063002/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-10-07 10:02:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 11:04:12]

Description was changed from

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
==========

to

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
==========

[commit-bot: I haz the power, 2016-10-07 11:04:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 11:06:14]

Description was changed from

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463
==========

to

==========
PlzNavigate: make ServiceWorker ForeignFetch work

This CL fixes an issue that was preventing foreign fetch to work on
subframes when browser-side-navigation was enabled. The issue was that
there was no way to retrieve the ServiceWorkerContext from the
navigation URLRequest, and so the ServiceWorker specified by the link
header could not be registered.

BUG=440463

Committed: https://crrev.com/37e10ddfe88bcf59a9f8065b16891ad0ae191f35
Cr-Commit-Position: refs/heads/master@{#423833}
==========

[commit-bot: I haz the power, 2016-10-07 11:06:15]

Patchset 2 (id:??) landed as
https://crrev.com/37e10ddfe88bcf59a9f8065b16891ad0ae191f35
Cr-Commit-Position: refs/heads/master@{#423833}