Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2399053003: [promises] fix deferred object leak (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] fix deferred object leak This patch sets `this` to be undefined when calling resolve and reject functions attached to the deferred. BUG=v8:5476 Committed: https://crrev.com/9d836ec64a42087e522ac9fb9804b3298f8fac1e Cr-Commit-Position: refs/heads/master@{#40056}

Patch Set 1 #

Patch Set 2 : test reject case too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M src/js/promise.js View 3 chunks +3 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-5476.js View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gsathya
4 years, 2 months ago (2016-10-06 18:17:54 UTC) #5
adamk
lgtm
4 years, 2 months ago (2016-10-06 18:21:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399053003/20001
4 years, 2 months ago (2016-10-06 18:26:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 18:29:29 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:29:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d836ec64a42087e522ac9fb9804b3298f8fac1e
Cr-Commit-Position: refs/heads/master@{#40056}

Powered by Google App Engine
This is Rietveld 408576698