Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2399033004: Fix corners of find bar view by using BubbleBackground instead of a (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix corners of find bar view by using BubbleBackground instead of a solid background. This fixes the appearance in Harmony. It has little visible effect pre-Harmony because the roundedness of the border and where it's drawn relative to the bg mean there's not much overlap between border and background. BUG=653717 Committed: https://crrev.com/a4629eb497b5d50a62a6757db82e9996cb69caf7 Cr-Commit-Position: refs/heads/master@{#424186}

Patch Set 1 #

Total comments: 2

Patch Set 2 : iwyu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M chrome/browser/ui/views/find_bar_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 4 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Evan Stade
4 years, 2 months ago (2016-10-06 22:55:19 UTC) #2
msw
lgtm with a nit https://codereview.chromium.org/2399033004/diff/1/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/2399033004/diff/1/chrome/browser/ui/views/find_bar_view.cc#newcode30 chrome/browser/ui/views/find_bar_view.cc:30: #include "ui/gfx/canvas.h" nit: remove
4 years, 2 months ago (2016-10-07 01:14:49 UTC) #3
Evan Stade
https://codereview.chromium.org/2399033004/diff/1/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/2399033004/diff/1/chrome/browser/ui/views/find_bar_view.cc#newcode30 chrome/browser/ui/views/find_bar_view.cc:30: #include "ui/gfx/canvas.h" On 2016/10/07 01:14:48, msw wrote: > nit: ...
4 years, 2 months ago (2016-10-10 17:26:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399033004/20001
4 years, 2 months ago (2016-10-10 17:26:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 18:19:49 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:22:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4629eb497b5d50a62a6757db82e9996cb69caf7
Cr-Commit-Position: refs/heads/master@{#424186}

Powered by Google App Engine
This is Rietveld 408576698