Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2398993004: DrMemory: Avoid capture with no capture callback set (Closed)

Created:
4 years, 2 months ago by Irfan
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DrMemory: Avoid capture with no capture callback set ScheduleNextFrame() has several entry points. Ensure capture timer is not set with no valid callback. BUG= Committed: https://crrev.com/edaad1c880436f1483c29410cd3852aae05be65b Cr-Commit-Position: refs/heads/master@{#423666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M remoting/protocol/webrtc_frame_scheduler_simple.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Irfan
PTAL This is the DrMemory failure: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20x64%29/builds/587/steps/memory%20test%3A%20remoting/logs/stdio
4 years, 2 months ago (2016-10-06 18:26:00 UTC) #5
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-06 20:33:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398993004/1
4 years, 2 months ago (2016-10-06 20:36:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:51:10 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:53:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edaad1c880436f1483c29410cd3852aae05be65b
Cr-Commit-Position: refs/heads/master@{#423666}

Powered by Google App Engine
This is Rietveld 408576698