Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2398943002: [mac] Use -[NSApp isActive] for checking if current app is active. (Closed)

Created:
4 years, 2 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, Mark Mentovai
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mac] Use -[NSApp isActive] for checking if current app is active. Use short version in RelaunchAppWithHelper() instead of [[NSRunningApplication currentApplication] isActive] BUG=650854 Committed: https://crrev.com/fe109cbea3a8e708609bfc16673684f274f18a6d Cr-Commit-Position: refs/heads/master@{#423716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/mac/relauncher.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Eugene But (OOO till 7-30)
Follow up cleanup for https://codereview.chromium.org/2394733002/
4 years, 2 months ago (2016-10-06 05:43:55 UTC) #4
Nico
lgtm, thanks. I checked that all calls to this are preceded by calls to RegisterBrowserCrApp().
4 years, 2 months ago (2016-10-06 15:59:18 UTC) #7
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-06 16:16:28 UTC) #10
Eugene But (OOO till 7-30)
Thanks for quick review!
4 years, 2 months ago (2016-10-06 22:37:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398943002/1
4 years, 2 months ago (2016-10-06 22:38:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 22:44:47 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 22:46:21 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe109cbea3a8e708609bfc16673684f274f18a6d
Cr-Commit-Position: refs/heads/master@{#423716}

Powered by Google App Engine
This is Rietveld 408576698