Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: media/base/video_decoder.h

Issue 239893002: Allow multiple concurrent Decode() requests in VideoDecoder interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index 2153dfda8a54d8f75ac29154d1d4106929517929..226b7b2f01f6e4ac4e2f9fd5a6e35b00476f37f5 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -47,11 +47,16 @@ class MEDIA_EXPORT VideoDecoder {
const PipelineStatusCB& status_cb) = 0;
// Requests a |buffer| to be decoded. The status of the decoder and decoded
- // frame are returned via the provided callback. Only one decode may be in
- // flight at any given time.
+ // frame are returned via the provided callback. Some decoders may allow
+ // decoding multiple buffers in parallel. Callers should call
+ // GetMaxDecodeRequests() to get number of buffers that may be decoded in
+ // parallel. Decoder must call |decode_cb| in the same order in which Decode()
+ // is called.
//
// Implementations guarantee that the callback will not be called from within
- // this method.
+ // this method and that |decode_cb| will not be blocked on the following
+ // Decode() calls (i.e. |decode_cb| will be called even Decode() is never
+ // called again).
//
// If the returned status is kOk:
// - Non-EOS (end of stream) frame contains decoded video data.
@@ -65,6 +70,8 @@ class MEDIA_EXPORT VideoDecoder {
// Some VideoDecoders may queue up multiple VideoFrames from a single
// DecoderBuffer, if we have any such queued frames this will return the next
// one. Otherwise we return a NULL VideoFrame.
+ //
+ // TODO(xhwang): Revisit this method.
virtual scoped_refptr<VideoFrame> GetDecodeOutput();
// Resets decoder state, fulfilling all pending DecodeCB and dropping extra
@@ -89,6 +96,9 @@ class MEDIA_EXPORT VideoDecoder {
// use a fixed set of VideoFrames for decoding.
virtual bool CanReadWithoutStalling() const;
+ // Returns maximum number of parallel decode requests.
+ virtual int GetMaxDecodeRequests() const;
+
private:
DISALLOW_COPY_AND_ASSIGN(VideoDecoder);
};
« no previous file with comments | « no previous file | media/base/video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698