Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2398863003: Don't filter the federated credentials in the account chooser. (Closed)

Created:
4 years, 2 months ago by vasilii
Modified:
4 years, 2 months ago
Reviewers:
dvadym
CC:
chromium-reviews, jam, gcasto+watchlist_chromium.org, darin-cc_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't filter the federated credentials in the account chooser. The filtering was introduced in https://codereview.chromium.org/2277793002 BUG=653364 Committed: https://crrev.com/641e5161d080e498899a4758608febdeba45e64c Cr-Commit-Position: refs/heads/master@{#423588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_request_task.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vasilii
Hi Vadym, please review.
4 years, 2 months ago (2016-10-06 17:12:03 UTC) #2
dvadym
LGTM
4 years, 2 months ago (2016-10-06 17:15:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398863003/1
4 years, 2 months ago (2016-10-06 17:17:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 18:07:34 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:09:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/641e5161d080e498899a4758608febdeba45e64c
Cr-Commit-Position: refs/heads/master@{#423588}

Powered by Google App Engine
This is Rietveld 408576698