Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

Issue 2398833004: Reflow comments in core/css/invalidation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
index 2a74594003418aa6f031707dd70f4719d072000e..19bf9c4e09ab0b84cdcb31e67f8356f077624ccc 100644
--- a/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
+++ b/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
@@ -54,7 +54,8 @@ static bool determineSelectorScopes(const CSSSelectorList& selectorList,
for (const CSSSelector* selector = selectorList.first(); selector;
selector = CSSSelectorList::next(*selector)) {
const CSSSelector* scopeSelector = 0;
- // This picks the widest scope, not the narrowest, to minimize the number of found scopes.
+ // This picks the widest scope, not the narrowest, to minimize the number of
+ // found scopes.
for (const CSSSelector* current = selector; current;
current = current->tagHistory()) {
// Prefer ids over classes.
@@ -64,7 +65,8 @@ static bool determineSelectorScopes(const CSSSelectorList& selectorList,
(!scopeSelector || scopeSelector->match() != CSSSelector::Id))
scopeSelector = current;
CSSSelector::RelationType relation = current->relation();
- // FIXME: it would be better to use setNeedsStyleRecalc for all shadow hosts matching
+ // FIXME: it would be better to use setNeedsStyleRecalc for all shadow
+ // hosts matching
// scopeSelector. Currently requests full style recalc.
if (relation == CSSSelector::ShadowDeep ||
relation == CSSSelector::ShadowPseudo)
@@ -90,20 +92,20 @@ static bool ruleAdditionMightRequireDocumentStyleRecalc(StyleRuleBase* rule) {
// This function is conservative. We only return false when we know that
// the added @rule can't require style recalcs.
switch (rule->type()) {
- case StyleRule::
- Import: // Whatever we import should do its own analysis, we don't need to invalidate the document here!
- case StyleRule::
- Page: // Page rules apply only during printing, we force a full-recalc before printing.
+ case StyleRule::Import: // Whatever we import should do its own analysis,
+ // we don't need to invalidate the document here!
+ case StyleRule::Page: // Page rules apply only during printing, we force a
+ // full-recalc before printing.
return false;
- case StyleRule::
- Media: // If the media rule doesn't apply, we could avoid recalc.
- case StyleRule::
- FontFace: // If the fonts aren't in use, we could avoid recalc.
- case StyleRule::
- Supports: // If we evaluated the supports-clause we could avoid recalc.
- case StyleRule::
- Viewport: // If the viewport doesn't match, we could avoid recalcing.
+ case StyleRule::Media: // If the media rule doesn't apply, we could avoid
+ // recalc.
+ case StyleRule::FontFace: // If the fonts aren't in use, we could avoid
+ // recalc.
+ case StyleRule::Supports: // If we evaluated the supports-clause we could
+ // avoid recalc.
+ case StyleRule::Viewport: // If the viewport doesn't match, we could avoid
+ // recalcing.
return true;
// These should all be impossible to reach:
@@ -120,9 +122,9 @@ static bool ruleAdditionMightRequireDocumentStyleRecalc(StyleRuleBase* rule) {
void StyleSheetInvalidationAnalysis::analyzeStyleSheet(
StyleSheetContents* styleSheetContents) {
- // Updating the style on the shadow DOM for image fallback content can bring us here when imports
- // are still getting loaded in the main document. Just need to exit early as we will return here
- // when the imports finish loading.
+ // Updating the style on the shadow DOM for image fallback content can bring
+ // us here when imports are still getting loaded in the main document. Just
+ // need to exit early as we will return here when the imports finish loading.
if (styleSheetContents->isLoading())
return;
« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698