Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2398833003: Fix double-delete in BatteryMonitor. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix double-delete in BatteryMonitor. BatterMonitorImpl is uniquely owned by its StrongBinding, so deleting it directly results in a double-delete. BUG=653298 Committed: https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723 Cr-Commit-Position: refs/heads/master@{#423536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M device/battery/battery_monitor_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/battery/battery_monitor_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dcheng
+timvolodine for OWNERS stamp +rockot to make sure I'm doing it all correctly
4 years, 2 months ago (2016-10-05 23:16:40 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-06 00:11:16 UTC) #5
timvolodine
On 2016/10/06 00:11:16, Ken Rockot wrote: > lgtm rs lgtm. Is this come kind of ...
4 years, 2 months ago (2016-10-06 13:08:41 UTC) #8
dcheng
On 2016/10/06 13:08:41, timvolodine wrote: > On 2016/10/06 00:11:16, Ken Rockot wrote: > > lgtm ...
4 years, 2 months ago (2016-10-06 15:13:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398833003/1
4 years, 2 months ago (2016-10-06 15:13:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 15:17:39 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:21:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723
Cr-Commit-Position: refs/heads/master@{#423536}

Powered by Google App Engine
This is Rietveld 408576698