Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: media/capture/video/video_capture_device_client.h

Issue 2398813002: Cleanup of video capture into GpuMemoryBuffer (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device_client.h
diff --git a/media/capture/video/video_capture_device_client.h b/media/capture/video/video_capture_device_client.h
index 821c58dbbd0097a7eaccb2f41e43ba238ccc2ee2..b01e080e38930dc2df167e31cd37a73bf9d48610 100644
--- a/media/capture/video/video_capture_device_client.h
+++ b/media/capture/video/video_capture_device_client.h
@@ -85,10 +85,8 @@ class CAPTURE_EXPORT VideoCaptureDeviceClient
// Returns an nullptr if allocation fails.
//
// When requested |storage| is PIXEL_STORAGE_CPU, a single shared memory
- // chunk is reserved; whereas for PIXEL_STORAGE_GPUMEMORYBUFFER, three
- // GpuMemoryBuffers in R_8 format representing I420 planes are reserved. The
- // output buffers stay reserved and mapped for use until the Buffer objects
- // are destroyed or returned.
+ // chunk is reserved. The output buffers stay reserved and mapped for use
+ // until the Buffer objects are destroyed or returned.
std::unique_ptr<Buffer> ReserveI420OutputBuffer(
const gfx::Size& dimensions,
media::VideoPixelStorage storage,
@@ -116,10 +114,6 @@ class CAPTURE_EXPORT VideoCaptureDeviceClient
static const int kMaxDroppedFrames = 150;
#endif // DCHECK_IS_ON()
- // Indication to the Client to copy-transform the incoming data into
- // GpuMemoryBuffers.
- const bool use_gpu_memory_buffers_;
-
media::VideoPixelFormat last_captured_pixel_format_;
DISALLOW_COPY_AND_ASSIGN(VideoCaptureDeviceClient);
« no previous file with comments | « media/capture/video/video_capture_buffer_tracker.h ('k') | media/capture/video/video_capture_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698