Disconnect It2Me session if the incoming connection is invalid

Disconnect It2Me session if the incoming connection is invalid

In a previous CL, I removed the It2MeConfirmationDialogFactory and instead
held on to an instance of the dialog which was then used, and destroyed, when
validating the incoming connection.  The assumption was that the It2Me
host would be destroyed when the user rejected the incoming connection.

This is not actually what happens, the host remains running and will
continue to receive these invalid requests until the web host times out
and kills the native messaging host process.  Due to this behavior,
we now see a crash when the remote user attempts to connect again.

Ideally we should stop the It2Me connection process completely if the
incoming request is rejected.  This change does that by calling
Disconnect() when a validation error occurs.  It also adds some DCHECKs
to ensure the validation code is called on the correct thread (even
for success cases) and updates the unit tests to work with these
stricter thread affinity requirements.

BUG=652490
Committed: https://crrev.com/bd36c87b70a3c88b3969b95208c4142e58c90ea3
Cr-Commit-Position: refs/heads/master@{#423325}

[joedow, 2016-10-05 21:57:18]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-05 21:58:02]

Description was changed from

==========
Disconnect It2Me session if the incoming connection is invalid

In a previous CL, I removed the It2MeConfirmationDialogFactory and instead
held on to an instance of it which was then used, and destroyed, when
validating the incoming connection.  The assumption was that the It2Me
host would be destroyed when the user rejected the incoming connection.

This is not actually what happens, the host remains running and will
continue to receive these invalid requests until the web host times out
and kills the native messaging host process.

Ideally we should stop the It2Me connection process completely if the
incoming request is rejected.  This change does that by calling
Disconnect() in case of a validation error.  It also adds some DCHECKs
to ensure the validation code is called on the correct thread (even
for success cases) and updates the unit tests to work with these new
threading requirements.

BUG=652490
==========

to

==========
Disconnect It2Me session if the incoming connection is invalid

In a previous CL, I removed the It2MeConfirmationDialogFactory and instead
held on to an instance of the dialog which was then used, and destroyed, when
validating the incoming connection.  The assumption was that the It2Me
host would be destroyed when the user rejected the incoming connection.

This is not actually what happens, the host remains running and will
continue to receive these invalid requests until the web host times out
and kills the native messaging host process.  Due to this behavior,
we now see a crash when the remote user attempts to connect again.

Ideally we should stop the It2Me connection process completely if the
incoming request is rejected.  This change does that by calling
Disconnect() when a validation error occurs.  It also adds some DCHECKs
to ensure the validation code is called on the correct thread (even
for success cases) and updates the unit tests to work with these
stricter thread affinity requirements.

BUG=652490
==========

[joedow, 2016-10-05 21:58:22]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-10-05 21:58:22]

PTAL!

[Sergey Ulanov, 2016-10-05 22:27:56]

lgtm

[commit-bot: I haz the power, 2016-10-05 22:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:37:14]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-05 22:48:53]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:49:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:56:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 22:58:14]

Description was changed from

==========
Disconnect It2Me session if the incoming connection is invalid

In a previous CL, I removed the It2MeConfirmationDialogFactory and instead
held on to an instance of the dialog which was then used, and destroyed, when
validating the incoming connection.  The assumption was that the It2Me
host would be destroyed when the user rejected the incoming connection.

This is not actually what happens, the host remains running and will
continue to receive these invalid requests until the web host times out
and kills the native messaging host process.  Due to this behavior,
we now see a crash when the remote user attempts to connect again.

Ideally we should stop the It2Me connection process completely if the
incoming request is rejected.  This change does that by calling
Disconnect() when a validation error occurs.  It also adds some DCHECKs
to ensure the validation code is called on the correct thread (even
for success cases) and updates the unit tests to work with these
stricter thread affinity requirements.

BUG=652490
==========

to

==========
Disconnect It2Me session if the incoming connection is invalid

In a previous CL, I removed the It2MeConfirmationDialogFactory and instead
held on to an instance of the dialog which was then used, and destroyed, when
validating the incoming connection.  The assumption was that the It2Me
host would be destroyed when the user rejected the incoming connection.

This is not actually what happens, the host remains running and will
continue to receive these invalid requests until the web host times out
and kills the native messaging host process.  Due to this behavior,
we now see a crash when the remote user attempts to connect again.

Ideally we should stop the It2Me connection process completely if the
incoming request is rejected.  This change does that by calling
Disconnect() when a validation error occurs.  It also adds some DCHECKs
to ensure the validation code is called on the correct thread (even
for success cases) and updates the unit tests to work with these
stricter thread affinity requirements.

BUG=652490

Committed: https://crrev.com/bd36c87b70a3c88b3969b95208c4142e58c90ea3
Cr-Commit-Position: refs/heads/master@{#423325}
==========

[commit-bot: I haz the power, 2016-10-05 22:58:15]

Patchset 2 (id:??) landed as
https://crrev.com/bd36c87b70a3c88b3969b95208c4142e58c90ea3
Cr-Commit-Position: refs/heads/master@{#423325}