third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp - Issue 2398793003: [Origin Trials] Clarify the distinction between trials and features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 2398793003: [Origin Trials] Clarify the distinction between trials and features (Closed)

Patch Set: Rebase; -DurableStorage, +WebVR Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

index 5c5129494a055940147dd705af9f8a9371d6e960..a4aaca80244ab05379cdf26da06921af474a3d2d 100644

--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

@@ -94,8 +94,7 @@ void installConditionalFeaturesForTests(

executionContext, OriginTrialContext::DontCreateIfNotExists);

if (type == &V8OriginTrialsTest::wrapperTypeInfo) {

- if (originTrialContext &&

- originTrialContext->isFeatureEnabled("Frobulate")) {

+ if (originTrialContext && originTrialContext->isTrialEnabled("Frobulate")) {

V8OriginTrialsTest::installOriginTrialsSampleAPI(

scriptState->isolate(), scriptState->world(), v8::Local<v8::Object>(),

prototypeObject, interfaceObject);