third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl - Issue 2398793003: [Origin Trials] Clarify the distinction between trials and features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl

Issue 2398793003: [Origin Trials] Clarify the distinction between trials and features (Closed)

Patch Set: Rebase; -DurableStorage, +WebVR Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp ('k') | third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl

index 3d14090f1928c2368d1227d5892c998e61d4ac28..b1e39cecb2579236befa5eb2a6e32b727e4fc3df 100644

--- a/third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl

@@ -23,7 +23,7 @@ bool OriginTrials::{{feature.first_lowered_name}}Enabled(ExecutionContext* execu

{% endif %}

OriginTrialContext* context = OriginTrialContext::from(executionContext, OriginTrialContext::DontCreateIfNotExists);

- return context && context->isFeatureEnabled("{{feature.origin_trial_feature_name}}");

+ return context && context->isTrialEnabled("{{feature.origin_trial_feature_name}}");

{% if feature.origin_trial_os %}

#else

return false;