Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp

Issue 2398793003: [Origin Trials] Clarify the distinction between trials and features (Closed)
Patch Set: Rebase; -DurableStorage, +WebVR Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ConditionalFeatures.h" 5 #include "bindings/core/v8/ConditionalFeatures.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/V8HTMLLinkElement.h" 8 #include "bindings/core/v8/V8HTMLLinkElement.h"
9 #include "bindings/core/v8/V8Navigator.h" 9 #include "bindings/core/v8/V8Navigator.h"
10 #include "bindings/core/v8/V8Window.h" 10 #include "bindings/core/v8/V8Window.h"
(...skipping 10 matching lines...) Expand all
21 // configuration of origin trial enabled attibutes and interfaces in IDL 21 // configuration of origin trial enabled attibutes and interfaces in IDL
22 // files. (crbug.com/615060) 22 // files. (crbug.com/615060)
23 ExecutionContext* executionContext = scriptState->getExecutionContext(); 23 ExecutionContext* executionContext = scriptState->getExecutionContext();
24 if (!executionContext) 24 if (!executionContext)
25 return; 25 return;
26 OriginTrialContext* originTrialContext = OriginTrialContext::from( 26 OriginTrialContext* originTrialContext = OriginTrialContext::from(
27 executionContext, OriginTrialContext::DontCreateIfNotExists); 27 executionContext, OriginTrialContext::DontCreateIfNotExists);
28 if (wrapperTypeInfo == &V8HTMLLinkElement::wrapperTypeInfo) { 28 if (wrapperTypeInfo == &V8HTMLLinkElement::wrapperTypeInfo) {
29 if (RuntimeEnabledFeatures::linkServiceWorkerEnabled() || 29 if (RuntimeEnabledFeatures::linkServiceWorkerEnabled() ||
30 (originTrialContext && 30 (originTrialContext &&
31 originTrialContext->isFeatureEnabled("ForeignFetch"))) { 31 originTrialContext->isTrialEnabled("ForeignFetch"))) {
32 V8HTMLLinkElement::installLinkServiceWorker( 32 V8HTMLLinkElement::installLinkServiceWorker(
33 scriptState->isolate(), scriptState->world(), v8::Local<v8::Object>(), 33 scriptState->isolate(), scriptState->world(), v8::Local<v8::Object>(),
34 prototypeObject, interfaceObject); 34 prototypeObject, interfaceObject);
35 } 35 }
36 } 36 }
37 } 37 }
38 38
39 namespace { 39 namespace {
40 40
41 InstallConditionalFeaturesFunction s_installConditionalFeaturesFunction = 41 InstallConditionalFeaturesFunction s_installConditionalFeaturesFunction =
(...skipping 10 matching lines...) Expand all
52 52
53 void installConditionalFeatures(const WrapperTypeInfo* type, 53 void installConditionalFeatures(const WrapperTypeInfo* type,
54 const ScriptState* scriptState, 54 const ScriptState* scriptState,
55 v8::Local<v8::Object> prototypeObject, 55 v8::Local<v8::Object> prototypeObject,
56 v8::Local<v8::Function> interfaceObject) { 56 v8::Local<v8::Function> interfaceObject) {
57 (*s_installConditionalFeaturesFunction)(type, scriptState, prototypeObject, 57 (*s_installConditionalFeaturesFunction)(type, scriptState, prototypeObject,
58 interfaceObject); 58 interfaceObject);
59 } 59 }
60 60
61 } // namespace blink 61 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698