[Extensions] Convert some ChromeSyncExtensionFunctions

chrome/browser/extensions/api/tabs/tabs_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 31 matching lines @@
 class PrefRegistrySyncable;
 }
 
 namespace extensions {
 
 // Converts a ZoomMode to its ZoomSettings representation.
 void ZoomModeToZoomSettings(zoom::ZoomController::ZoomMode zoom_mode,
                             api::tabs::ZoomSettings* zoom_settings);
 
 // Windows
-class WindowsGetFunction : public ChromeSyncExtensionFunction {
+class WindowsGetFunction : public UIThreadExtensionFunction {
   ~WindowsGetFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.get", WINDOWS_GET)
 };
-class WindowsGetCurrentFunction : public ChromeSyncExtensionFunction {
+class WindowsGetCurrentFunction : public UIThreadExtensionFunction {
   ~WindowsGetCurrentFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.getCurrent", WINDOWS_GETCURRENT)
 };
-class WindowsGetLastFocusedFunction : public ChromeSyncExtensionFunction {
+class WindowsGetLastFocusedFunction : public UIThreadExtensionFunction {
   ~WindowsGetLastFocusedFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.getLastFocused", WINDOWS_GETLASTFOCUSED)
 };
-class WindowsGetAllFunction : public ChromeSyncExtensionFunction {
+class WindowsGetAllFunction : public UIThreadExtensionFunction {
   ~WindowsGetAllFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.getAll", WINDOWS_GETALL)
 };
-class WindowsCreateFunction : public ChromeSyncExtensionFunction {
+class WindowsCreateFunction : public UIThreadExtensionFunction {
   ~WindowsCreateFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   // Returns whether the window should be created in incognito mode.
   // |create_data| are the options passed by the extension. It may be NULL.
   // |urls| is the list of urls to open. If we are creating an incognito window,
   // the function will remove these urls which may not be opened in incognito
   // mode.  If window creation leads the browser into an erroneous state,
   // |is_error| is set to true (also, error_ member variable is assigned
   // the proper error message).
   bool ShouldOpenIncognitoWindow(
       const api::windows::Create::Params::CreateData* create_data,
       std::vector<GURL>* urls,
-      bool* is_error);
+      std::string* error);
   DECLARE_EXTENSION_FUNCTION("windows.create", WINDOWS_CREATE)
 };
-class WindowsUpdateFunction : public ChromeSyncExtensionFunction {
+class WindowsUpdateFunction : public UIThreadExtensionFunction {
   ~WindowsUpdateFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.update", WINDOWS_UPDATE)
 };
-class WindowsRemoveFunction : public ChromeSyncExtensionFunction {
+class WindowsRemoveFunction : public UIThreadExtensionFunction {
   ~WindowsRemoveFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("windows.remove", WINDOWS_REMOVE)
 };
 
 // Tabs
-class TabsGetFunction : public ChromeSyncExtensionFunction {
+class TabsGetFunction : public UIThreadExtensionFunction {
   ~TabsGetFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.get", TABS_GET)
 };
-class TabsGetCurrentFunction : public ChromeSyncExtensionFunction {
+class TabsGetCurrentFunction : public UIThreadExtensionFunction {
   ~TabsGetCurrentFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.getCurrent", TABS_GETCURRENT)
 };
-class TabsGetSelectedFunction : public ChromeSyncExtensionFunction {
+class TabsGetSelectedFunction : public UIThreadExtensionFunction {
   ~TabsGetSelectedFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.getSelected", TABS_GETSELECTED)
 };
-class TabsGetAllInWindowFunction : public ChromeSyncExtensionFunction {
+class TabsGetAllInWindowFunction : public UIThreadExtensionFunction {
   ~TabsGetAllInWindowFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.getAllInWindow", TABS_GETALLINWINDOW)
 };
-class TabsQueryFunction : public ChromeSyncExtensionFunction {
+class TabsQueryFunction : public UIThreadExtensionFunction {
   ~TabsQueryFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.query", TABS_QUERY)
 };
-class TabsCreateFunction : public ChromeSyncExtensionFunction {
+class TabsCreateFunction : public UIThreadExtensionFunction {
   ~TabsCreateFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.create", TABS_CREATE)
 };
-class TabsDuplicateFunction : public ChromeSyncExtensionFunction {
+class TabsDuplicateFunction : public UIThreadExtensionFunction {
   ~TabsDuplicateFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.duplicate", TABS_DUPLICATE)
 };
-class TabsHighlightFunction : public ChromeSyncExtensionFunction {
+class TabsHighlightFunction : public UIThreadExtensionFunction {
   ~TabsHighlightFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   bool HighlightTab(TabStripModel* tabstrip,
                     ui::ListSelectionModel* selection,
                     int* active_index,
-                    int index);
+                    int index,
+                    std::string* error);
   DECLARE_EXTENSION_FUNCTION("tabs.highlight", TABS_HIGHLIGHT)
 };
 class TabsUpdateFunction : public ChromeAsyncExtensionFunction {
  public:
   TabsUpdateFunction();
 
  protected:
   ~TabsUpdateFunction() override {}
   virtual bool UpdateURL(const std::string& url,
                          int tab_id,
                          bool* is_async);
   virtual void PopulateResult();
 
   content::WebContents* web_contents_;
 
  private:
   bool RunAsync() override;
   void OnExecuteCodeFinished(const std::string& error,
                              const GURL& on_url,
                              const base::ListValue& script_result);
 
   DECLARE_EXTENSION_FUNCTION("tabs.update", TABS_UPDATE)
 };
-class TabsMoveFunction : public ChromeSyncExtensionFunction {
+class TabsMoveFunction : public UIThreadExtensionFunction {
   ~TabsMoveFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   bool MoveTab(int tab_id,
                int* new_index,
                int iteration,
                base::ListValue* tab_values,
-               int* window_id);
+               int* window_id,
+               std::string* error);
   DECLARE_EXTENSION_FUNCTION("tabs.move", TABS_MOVE)
 };
-class TabsReloadFunction : public ChromeSyncExtensionFunction {
+class TabsReloadFunction : public UIThreadExtensionFunction {
   ~TabsReloadFunction() override {}
-  bool RunSync() override;
+  ResponseAction Run() override;
   DECLARE_EXTENSION_FUNCTION("tabs.reload", TABS_RELOAD)
 };
-class TabsRemoveFunction : public ChromeSyncExtensionFunction {
+class TabsRemoveFunction : public UIThreadExtensionFunction {
   ~TabsRemoveFunction() override {}
-  bool RunSync() override;
-  bool RemoveTab(int tab_id);
+  ResponseAction Run() override;
+  bool RemoveTab(int tab_id, std::string* error);
   DECLARE_EXTENSION_FUNCTION("tabs.remove", TABS_REMOVE)
 };
 class TabsDetectLanguageFunction : public ChromeAsyncExtensionFunction,
                                    public content::NotificationObserver {
  private:
   ~TabsDetectLanguageFunction() override {}
   bool RunAsync() override;
 
   void Observe(int type,
                const content::NotificationSource& source,
@@ skipping 140 matching lines @@
 
   // ExtensionFunction:
   ExtensionFunction::ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(TabsDiscardFunction);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_