Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: content/public/browser/content_browser_client.h

Issue 2398783002: Rename a bunch of Mojo Application stuff to reference Services. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/browser_main_parts.h ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 44bab183d497cb6bd96289f88de98df1b64e46b9..d96ec4321ea90b6c2fe65f1ff4fb305101175150 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -21,8 +21,8 @@
#include "content/public/browser/navigation_throttle.h"
#include "content/public/common/content_client.h"
#include "content/public/common/media_stream_request.h"
-#include "content/public/common/mojo_application_info.h"
#include "content/public/common/resource_type.h"
+#include "content/public/common/service_info.h"
#include "content/public/common/socket_permission_request.h"
#include "content/public/common/window_container_type.h"
#include "media/audio/audio_manager.h"
@@ -649,12 +649,12 @@ class CONTENT_EXPORT ContentBrowserClient {
BrowserContext* browser_context,
const GURL& url);
- // Generate a Shell user-id for the supplied browser context. Defaults to
+ // Generate a Service user-id for the supplied browser context. Defaults to
// returning a random GUID.
- virtual std::string GetShellUserIdForBrowserContext(
+ virtual std::string GetServiceUserIdForBrowserContext(
BrowserContext* browser_context);
- // Allows to register browser Mojo interfaces exposed through the
+ // Allows to register browser interfaces exposed through the
// RenderProcessHost. Note that interface factory callbacks added to
// |registry| will by default be run immediately on the IO thread, unless a
// task runner is provided.
@@ -682,30 +682,28 @@ class CONTENT_EXPORT ContentBrowserClient {
shell::InterfaceRegistry* registry,
GpuProcessHost* render_process_host) {}
- using StaticMojoApplicationMap = std::map<std::string, MojoApplicationInfo>;
+ using StaticServiceMap = std::map<std::string, ServiceInfo>;
- // Registers Mojo applications to be loaded in the browser process by the
- // browser's global Mojo shell.
- virtual void RegisterInProcessMojoApplications(
- StaticMojoApplicationMap* apps) {}
+ // Registers services to be loaded in the browser process by the Service
+ // Manager.
+ virtual void RegisterInProcessServices(StaticServiceMap* services) {}
- using OutOfProcessMojoApplicationMap = std::map<std::string, base::string16>;
+ using OutOfProcessServiceMap = std::map<std::string, base::string16>;
- // Registers Mojo applications to be loaded out of the browser process, in a
- // sandboxed utility process. The value of each map entry should be the
- // process name to use for the application's host process when launched.
- virtual void RegisterOutOfProcessMojoApplications(
- OutOfProcessMojoApplicationMap* apps) {}
+ // Registers services to be loaded out of the browser process, in a sandboxed
+ // utility process. The value of each map entry should be the process name to
+ // use for the service's host process when launched.
+ virtual void RegisterOutOfProcessServices(OutOfProcessServiceMap* services) {}
- // Registers Mojo applications to be loaded out of the browser process (in
- // a utility process) without the sandbox.
+ // Registers services to be loaded out of the browser process (in a utility
+ // process) without the sandbox.
//
- // WARNING: This path is NOT recommended! If a Mojo application needs a
- // service that is only available out of the sandbox, it could ask the browser
- // process to provide it (e.g. through OverrideFrameMojoShellServices()). Only
- // use this method when that approach does not work.
- virtual void RegisterUnsandboxedOutOfProcessMojoApplications(
- OutOfProcessMojoApplicationMap* apps) {}
+ // WARNING: This path is NOT recommended! If a service needs another service
+ // that is only available out of the sandbox, it could ask the browser
+ // process to provide it. Only use this method when that approach does not
+ // work.
+ virtual void RegisterUnsandboxedOutOfProcessServices(
+ OutOfProcessServiceMap* services) {}
// Allow the embedder to provide a dictionary loaded from a JSON file
// resembling a service manifest whose capabilities section will be merged
« no previous file with comments | « content/public/browser/browser_main_parts.h ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698