Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2398773003: Orientation request may arrive before the window is created. (Closed)

Created:
4 years, 2 months ago by oshima
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Orientation request may arrive before the window is created. Instead of adding another map, I introduced AppWindowInfo which stores information about the arc windows w/o actual window. Technically, we can move more from AppWindow, but we can revisit it later if we want. BUG=31836336 TEST=ChromeLauncherControllerOrientationTest.ArcOrientationLockBeforeWindowReady Review-Url: https://codereview.chromium.org/2384773002 Cr-Commit-Position: refs/heads/master@{#422635} (cherry picked from commit f086a6dfa73928036f55434bd4ec4576478aaf90) Committed: https://chromium.googlesource.com/chromium/src/+/9d026fec691ce55e0319116769615e86c64466cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -126 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 21 chunks +148 lines, -118 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 2 months ago (2016-10-06 01:54:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d026fec691ce55e0319116769615e86c64466cc.

Powered by Google App Engine
This is Rietveld 408576698