Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pdf/out_of_process_instance.h

Issue 2398763002: Add font substitution metric for Linux (Closed)
Patch Set: No ScopedSubstFont in PDFiumEngineExports Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/out_of_process_instance.h
diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h
index a998537dfd1e27548cf580d50715c68c928afb51..0e2e69ea36f031daafea03fe1aa71e239db296c0 100644
--- a/pdf/out_of_process_instance.h
+++ b/pdf/out_of_process_instance.h
@@ -128,6 +128,7 @@ class OutOfProcessInstance : public pp::Instance,
void DocumentPaintOccurred() override;
void DocumentLoadComplete(int page_count) override;
void DocumentLoadFailed() override;
+ void FontSubstituted() override;
pp::Instance* GetPluginInstance() override;
void DocumentHasUnsupportedFeature(const std::string& feature) override;
void DocumentLoadProgress(uint32_t available, uint32_t doc_size) override;
@@ -309,6 +310,12 @@ class OutOfProcessInstance : public pp::Instance,
// the stats if a feature shows up many times per document.
std::set<std::string> unsupported_features_reported_;
+#if defined(OS_LINUX)
+ // Keeps track of whether font substitution has been reported, so we avoid
+ // spamming the stats if a document requested multiple substitutes.
+ bool font_substitution_reported_;
+#endif
+
// Number of pages in print preview mode, 0 if not in print preview mode.
int print_preview_page_count_;
std::vector<int> print_preview_page_numbers_;
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698