third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2398733004: Do not SendPasswordForms when LocalFrame is being detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2398733004: Do not SendPasswordForms when LocalFrame is being detached (Closed)

Patch Set: Rename to isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 31dccf7ce79d4712ffe1406454109bdc41eb5dda..38269f0f9930117de9489404270140c54eed9224 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -379,6 +379,8 @@ void LocalFrame::reload(FrameLoadType loadType,

}

void LocalFrame::detach(FrameDetachType type) {

+ m_detached = true;

PluginScriptForbiddenScope forbidPluginDestructorScripting;

m_loader.stopAllLoaders();

// Don't allow any new child frames to load in this frame: attaching a new