Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Issue 2398733002: Make the AbstractParallelRebaselineCommand rebaseline function public/non-protected. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
index abe3f60e7802c8096790e1b5dd92547b3b9090b6..a721798acddb689c1ff9014aab9e7a490f24930a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
@@ -411,7 +411,7 @@ class TestRebaselineJson(BaseTestCase):
self._write(self.mac_expectations_path, "Bug(x) userscripts/first-test.html [ Failure ]\n")
self._write("userscripts/first-test.html", "Dummy test contents")
- self.command._rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
+ self.command.rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
self.assertEqual(self.tool.executive.calls, [])
@@ -419,7 +419,7 @@ class TestRebaselineJson(BaseTestCase):
self._setup_mock_build_data()
self._write("userscripts/first-test.html", "Dummy test contents")
- self.command._rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
+ self.command.rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
# Note that we have one run_in_parallel() call followed by a run_command()
self.assertEqual(
@@ -437,7 +437,7 @@ class TestRebaselineJson(BaseTestCase):
self._setup_mock_build_data()
self._write("userscripts/first-test.html", "Dummy test contents")
- self.command._rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7 (dbg)"): ["txt", "png"]}})
+ self.command.rebaseline(self.options(), {"userscripts/first-test.html": {Build("MOCK Win7 (dbg)"): ["txt", "png"]}})
# Note that we have one run_in_parallel() call followed by a run_command()
self.assertEqual(
@@ -454,7 +454,7 @@ class TestRebaselineJson(BaseTestCase):
def test_no_optimize(self):
self._setup_mock_build_data()
self._write("userscripts/first-test.html", "Dummy test contents")
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(optimize=False),
{"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
@@ -471,7 +471,7 @@ class TestRebaselineJson(BaseTestCase):
def test_results_directory(self):
self._setup_mock_build_data()
self._write("userscripts/first-test.html", "Dummy test contents")
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(optimize=False, results_directory='/tmp'),
{"userscripts/first-test.html": {Build("MOCK Win7"): ["txt", "png"]}})
@@ -513,7 +513,7 @@ class TestRebaselineJsonUpdatesExpectationsFiles(BaseTestCase):
self._write("userscripts/first-test.html", "Dummy test contents")
self._setup_mock_build_data()
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(),
{"userscripts/first-test.html": {Build("MOCK Mac10.11"): ["txt", "png"]}})
@@ -527,7 +527,7 @@ class TestRebaselineJsonUpdatesExpectationsFiles(BaseTestCase):
self._write(self.mac_expectations_path, "Bug(x) userscripts/first-test.html [ Failure ]\n")
self._write("userscripts/first-test.html", "Dummy test contents")
self._setup_mock_build_data()
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(),
{"userscripts/first-test.html": {Build("MOCK Mac10.11"): ["txt", "png"]}})
new_expectations = self._read(self.mac_expectations_path)
@@ -543,7 +543,7 @@ class TestRebaselineJsonUpdatesExpectationsFiles(BaseTestCase):
self._write("userscripts/first-test.html", "Dummy test contents")
self._setup_mock_build_data()
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(),
{"userscripts/first-test.html": {Build("MOCK Mac10.11"): ["txt", "png"]}})
@@ -563,7 +563,7 @@ class TestRebaselineJsonUpdatesExpectationsFiles(BaseTestCase):
self._write("userscripts/first-test.html", "Dummy test contents")
self._setup_mock_build_data()
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(),
{"userscripts/first-test.html": {Build("MOCK Mac10.11"): ["txt", "png"]}})
@@ -583,7 +583,7 @@ class TestRebaselineJsonUpdatesExpectationsFiles(BaseTestCase):
self._write("userscripts/first-test.html", "Dummy test contents")
self._setup_mock_build_data()
- self.command._rebaseline(
+ self.command.rebaseline(
self.options(),
{"userscripts/first-test.html": {Build("MOCK Mac10.11"): ["txt", "png"]}})

Powered by Google App Engine
This is Rietveld 408576698