Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2398723002:
Fix crash in aura::Window::GetHost (Closed)
|
Created:
4 years, 2 months ago by joone Modified:
4 years, 2 months ago Reviewers:
Elliot Glaysher CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix crash in aura::Window::GetHost
|owning_window->GetHost()| could return null so we need to check it.
BUG=653039
Committed: https://crrev.com/880dd7465806564cb4eac1cd4725a84cc6f817b6
Cr-Commit-Position: refs/heads/master@{#423269}
Patch Set 1 #Patch Set 2 #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by joone.hur@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by joone.hur@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
joone.hur@intel.com changed reviewers: + erg@chromium.org
Hi erg@ could you review this CL?
Description was changed from ========== Fix Crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ========== to ========== Fix Crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ==========
Description was changed from ========== Fix Crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ========== to ========== Fix crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by joone.hur@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ========== to ========== Fix crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 ========== to ========== Fix crash in aura::Window::GetHost |owning_window->GetHost()| could return null so we need to check it. BUG=653039 Committed: https://crrev.com/880dd7465806564cb4eac1cd4725a84cc6f817b6 Cr-Commit-Position: refs/heads/master@{#423269} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/880dd7465806564cb4eac1cd4725a84cc6f817b6 Cr-Commit-Position: refs/heads/master@{#423269} |
