Add constructor for MediaStreamAudioSourceNode

Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129, 626449
TEST=constructor/mediastreamaudiosource.html

Committed: https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76
Cr-Commit-Position: refs/heads/master@{#424174}

[Raymond Toy, 2016-10-05 18:26:16]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:33:17]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-06 15:37:40]

Description was changed from

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html
==========

to

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuu...
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html
==========

[Raymond Toy, 2016-10-06 15:39:01]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org, tkent@chromium.org

[Raymond Toy, 2016-10-06 15:39:01]

PTAL.

tkent: Don't know if you need to look at this; it's a bug in the implementation
of the original intent for adding constructors.

[hongchan, 2016-10-06 17:51:43]

lgtm with nits

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
(right):

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html:16:
audit.defineTask("initialize", function (taskDone) {
I don't think creating a context as a task is necessary. Why don't we just
create a context and move on?

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
(right):

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h:93:
BaseAudioContext*,
Why the constructor above is using different reference of AudioContext? (* and
&)

[tkent, 2016-10-06 23:13:44]

lgtm

On 2016/10/06 at 15:39:01, rtoy wrote:
> tkent: Don't know if you need to look at this; it's a bug in the
implementation of the original intent for adding constructors.

It's good to involve an API owner to check if the web-exposed change belongs to
the approved intent.

[Raymond Toy, 2016-10-07 15:18:00]

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
(right):

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html:16:
audit.defineTask("initialize", function (taskDone) {
On 2016/10/06 17:51:43, hoch wrote:
> I don't think creating a context as a task is necessary. Why don't we just
> create a context and move on?

We could, but I kind of like it as an initialization step to make it clearer
that we're creating one context that is being used for all of the following
tests. (Because we never start the context.)

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
(right):

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h:93:
BaseAudioContext*,
On 2016/10/06 17:51:43, hoch wrote:
> Why the constructor above is using different reference of AudioContext? (* and
> &)

All the other constructors do this, and the generated code passes in
AudioContext*.

[Raymond Toy, 2016-10-07 15:57:00]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:25:53]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-10 15:38:34]

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html
(right):

https://codereview.chromium.org/2398713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html:16:
audit.defineTask("initialize", function (taskDone) {
On 2016/10/07 15:18:00, Raymond Toy wrote:
> On 2016/10/06 17:51:43, hoch wrote:
> > I don't think creating a context as a task is necessary. Why don't we just
> > create a context and move on?
> 
> We could, but I kind of like it as an initialization step to make it clearer
> that we're creating one context that is being used for all of the following
> tests. (Because we never start the context.)

Misunderstood the comment.  Simplified as requested.

[Raymond Toy, 2016-10-10 15:38:51]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-10-10 15:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2398713002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-10-10 15:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 17:16:29]

Description was changed from

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuu...
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html
==========

to

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuu...
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html
==========

[commit-bot: I haz the power, 2016-10-10 17:16:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 17:19:29]

Description was changed from

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuu...
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html
==========

to

==========
Add constructor for MediaStreamAudioSourceNode

This was missed when the other constructors were implemented.

The original intent and feature:
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuu...
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=653129,626449
TEST=constructor/mediastreamaudiosource.html

Committed: https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76
Cr-Commit-Position: refs/heads/master@{#424174}
==========

[commit-bot: I haz the power, 2016-10-10 17:19:30]

Patchset 2 (id:??) landed as
https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76
Cr-Commit-Position: refs/heads/master@{#424174}