Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2398703004: Adding feature usage count for OffscreenCanvas (Closed)

Created:
4 years, 2 months ago by xidachen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding feature usage count for OffscreenCanvas This CL adds [MeasureAs=xxx] in the .idl files that corresponding to the OffscreenCanvas creation. Also, we found that PS#2 has compilation error, and looks like putting MeasureAs in an interface that has a partial interface triggers the error. PS#3 is one way to fix it. BUG=653599, 653913 Committed: https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430 Cr-Commit-Position: refs/heads/master@{#424363}

Patch Set 1 #

Patch Set 2 : drop Creation #

Patch Set 3 : fix bindings #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
xidachen
PTAL
4 years, 2 months ago (2016-10-06 17:22:53 UTC) #2
Justin Novosad
Drop the "Creation". Just "OffscreenCanvas". It's cleaner.
4 years, 2 months ago (2016-10-06 17:32:34 UTC) #3
xidachen
On 2016/10/06 17:32:34, Justin Novosad wrote: > Drop the "Creation". Just "OffscreenCanvas". It's cleaner. Done. ...
4 years, 2 months ago (2016-10-06 17:36:51 UTC) #4
Justin Novosad
On 2016/10/06 17:36:51, xidachen wrote: > On 2016/10/06 17:32:34, Justin Novosad wrote: > > Drop ...
4 years, 2 months ago (2016-10-06 21:03:07 UTC) #5
jwd
lgtm
4 years, 2 months ago (2016-10-07 15:08:33 UTC) #6
xidachen
adding haraken@ and yukishiino@ as PS#3 changes binding files.
4 years, 2 months ago (2016-10-07 15:43:30 UTC) #14
xidachen
On 2016/10/07 15:43:30, xidachen wrote: > adding haraken@ and yukishiino@ as PS#3 changes binding files. ...
4 years, 2 months ago (2016-10-11 00:27:27 UTC) #15
haraken
LGTM
4 years, 2 months ago (2016-10-11 01:53:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398703004/50001
4 years, 2 months ago (2016-10-11 02:06:30 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 2 months ago (2016-10-11 03:48:45 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 03:50:56 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430
Cr-Commit-Position: refs/heads/master@{#424363}

Powered by Google App Engine
This is Rietveld 408576698